Embeds the entitlements file in the binary in simulator builds.

Embeds the entitlements file in the binary in simulator builds.

Refactor the code to generate the entitlements file from codesign.py
in a file using the "generate-entitlements" command.

Only generate it for the default toolchain as Info.plist is only
generated for the default toolchain.

BUG=626686
Committed: https://crrev.com/0f93390b516605f8487de6ec12956b00c3291a6c
Cr-Commit-Position: refs/heads/master@{#409248}

[sdefresne, 2016-07-28 17:56:24]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 17:56:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 18:03:34]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[sdefresne, 2016-07-28 18:04:03]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, justincohen@chromium.org

[sdefresne, 2016-07-28 18:04:03]

Please take a look.

Work-around is for http://crbug.com/632412

[sdefresne, 2016-07-28 18:11:17]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 18:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 18:20:38]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Dirk Pranke, 2016-07-28 19:06:02]

lgtm if we get the GN issue fixed ...

[justincohen, 2016-07-29 01:35:23]

justincohen@chromium.org changed reviewers:
+ dba@chromium.org, smut@google.com

[justincohen, 2016-07-29 01:35:23]

I wonder if this is failing because the profiles aren't installed on simulator
builders.  smut@/dba@ do you know if that's the case?

[smut, 2016-07-29 21:27:05]

On 2016/07/29 01:35:23, justincohen wrote:
> I wonder if this is failing because the profiles aren't installed on simulator
> builders.  smut@/dba@ do you know if that's the case?

Downstream they are installed. Upstream I don't think they are supposed to be
installed on simulator or device bots.

[dba (chromium), 2016-07-29 21:34:14]

On 2016/07/29 21:27:05, smut wrote:
> On 2016/07/29 01:35:23, justincohen wrote:
> > I wonder if this is failing because the profiles aren't installed on
simulator
> > builders.  smut@/dba@ do you know if that's the case?
> 
> Downstream they are installed. Upstream I don't think they are supposed to be
> installed on simulator or device bots.

Correct. m4 bots do not get bootstrapped with BLING_BUILDER.

[justincohen, 2016-07-29 22:28:10]

https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
build/config/ios/codesign.py:223: def GenerateEntitlements(bundle_identifier,
provisioning_profile, args):
If the upstream bots can have an empty provisioning profile, we could just pass
in None for provisioning_profile.entitlements and 
provisioning_profile.team_identifier, maybe?

[sdefresne, 2016-08-02 05:43:07]

On 2016/07/29 22:28:10, justincohen wrote:
>
https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
> File build/config/ios/codesign.py (right):
> 
>
https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
> build/config/ios/codesign.py:223: def GenerateEntitlements(bundle_identifier,
> provisioning_profile, args):
> If the upstream bots can have an empty provisioning profile, we could just
pass
> in None for provisioning_profile.entitlements and 
> provisioning_profile.team_identifier, maybe?

I think the simplest would be to disable entitlements in simulator builds if
code signing is disabled (or add another variable to control this).

[justincohen, 2016-08-02 14:39:16]

Won't that defeat the purpose of this CL?  If we don't embed entitlements,
upstream iOS bots will fail during any keychain tests.

[sdefresne, 2016-08-02 15:01:25]

On 2016/08/02 14:39:16, justincohen wrote:
> Won't that defeat the purpose of this CL?  If we don't embed entitlements,
> upstream iOS bots will fail during any keychain tests.

Yeah, but if we do not have a mobile provisioning installed we cannot generate
the entitlements either.

[sdefresne, 2016-08-02 16:54:50]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:55:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-02 16:58:57]

justincohen: PTAL

https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2187343003/diff/20001/build/config/ios/codesi...
build/config/ios/codesign.py:223: def GenerateEntitlements(bundle_identifier,
provisioning_profile, args):
On 2016/07/29 22:28:10, justincohen wrote:
> If the upstream bots can have an empty provisioning profile, we could just
pass
> in None for provisioning_profile.entitlements and 
> provisioning_profile.team_identifier, maybe?

Done.

[justincohen, 2016-08-02 17:04:51]

lgtm

[sdefresne, 2016-08-02 17:06:41]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-02 17:07:51]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-08-02 17:07:52]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-08-02 17:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2187343003/#ps60001
(title: "Fix typo breaking code signing (not exercised by the bots).")

[commit-bot: I haz the power, 2016-08-02 17:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:18:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-02 18:20:36]

Description was changed from

==========
Embeds the entitlements file in the binary in simulator builds.

Refactor the code to generate the entitlements file from codesign.py
in a file using the "generate-entitlements" command.

Only generate it for the default toolchain as Info.plist is only
generated for the default toolchain.

BUG=626686
==========

to

==========
Embeds the entitlements file in the binary in simulator builds.

Refactor the code to generate the entitlements file from codesign.py
in a file using the "generate-entitlements" command.

Only generate it for the default toolchain as Info.plist is only
generated for the default toolchain.

BUG=626686

Committed: https://crrev.com/0f93390b516605f8487de6ec12956b00c3291a6c
Cr-Commit-Position: refs/heads/master@{#409248}
==========

[commit-bot: I haz the power, 2016-08-02 18:20:37]

Patchset 4 (id:??) landed as
https://crrev.com/0f93390b516605f8487de6ec12956b00c3291a6c
Cr-Commit-Position: refs/heads/master@{#409248}