Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: components/password_manager/core/browser/login_database_ios_unittest.cc

Issue 2180773002: Disable broken iOS10 password manager tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database_ios_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_ios_unittest.cc b/components/password_manager/core/browser/login_database_ios_unittest.cc
index 201bafe5fbe7108bac47308b2649e24ec5b2e72d..b558013c9d81ff591fa93e7d6d05c875bae06d3c 100644
--- a/components/password_manager/core/browser/login_database_ios_unittest.cc
+++ b/components/password_manager/core/browser/login_database_ios_unittest.cc
@@ -82,6 +82,13 @@ size_t LoginDatabaseIOSTest::GetKeychainSize() {
}
TEST_F(LoginDatabaseIOSTest, KeychainStorage) {
+#if TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): Broken by iOS10.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
+
base::string16 test_passwords[] = {
base::ASCIIToUTF16("foo"), base::ASCIIToUTF16("bar"),
base::WideToUTF16(L"\u043F\u0430\u0440\u043E\u043B\u044C"),
@@ -101,6 +108,13 @@ TEST_F(LoginDatabaseIOSTest, KeychainStorage) {
}
TEST_F(LoginDatabaseIOSTest, UpdateLogin) {
+#if TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): Broken by iOS10.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
+
PasswordForm form;
form.origin = GURL("http://0.com");
form.signon_realm = "http://www.example.com";
@@ -125,6 +139,13 @@ TEST_F(LoginDatabaseIOSTest, UpdateLogin) {
}
TEST_F(LoginDatabaseIOSTest, RemoveLogin) {
+#if TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): Broken by iOS10.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
+
PasswordForm form;
form.signon_realm = "www.example.com";
form.action = GURL("www.example.com/action");
@@ -143,6 +164,13 @@ TEST_F(LoginDatabaseIOSTest, RemoveLogin) {
}
TEST_F(LoginDatabaseIOSTest, RemoveLoginsCreatedBetween) {
+#if TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): Broken by iOS10.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
+
PasswordForm forms[3];
forms[0].origin = GURL("http://0.com");
forms[0].signon_realm = "http://www.example.com";
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698