Disable broken iOS10 password manager tests.

components/password_manager/core/browser/login_database_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
+#include "base/ios/ios_util.h"

[rohitrao (ping after 24h), 2016/07/24 23:04:55]

This is a cross-platform test, so this include will need to be behind OS_IOS. 
We'll also need to conditionally disable the test based on OS version.

[justincohen, 2016/07/25 15:11:52]

Done.

 #include "base/memory/scoped_vector.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/os_crypt/os_crypt_mocker.h"
@@ skipping 178 matching lines @@
     // Clear state.
     db().RemoveLoginsCreatedBetween(now, base::Time());
   }
 
   base::ScopedTempDir temp_dir_;
   base::FilePath file_;
   std::unique_ptr<LoginDatabase> db_;
 };
 
 TEST_F(LoginDatabaseTest, Logins) {
+#if TARGET_IPHONE_SIMULATOR
+  // TODO(crbug.com/619982): Broken by iOS10.

[rohitrao (ping after 24h), 2016/07/24 23:04:55]

I would be more specific in this comment and say that we believe this is broken
because of a bug in the iOS 10 simulator (that we expect to be fixed?).

[justincohen, 2016/07/25 15:11:52]

Done.

+  if (base::ios::IsRunningOnIOS10OrLater()) {
+    return;
+  }
+#endif
   ScopedVector<autofill::PasswordForm> result;
 
   // Verify the database is empty.
   EXPECT_TRUE(db().GetAutofillableLogins(&result));
   EXPECT_EQ(0U, result.size());
 
   // Example password form.
   PasswordForm form;
   GenerateExamplePasswordForm(&form);
 
@@ skipping 1432 matching lines @@
                         LoginDatabaseMigrationTest,
                         testing::Range(1, kCurrentVersionNumber + 1));
 INSTANTIATE_TEST_CASE_P(MigrationToVCurrent,
                         LoginDatabaseMigrationTestV9,
                         testing::Values(9));
 INSTANTIATE_TEST_CASE_P(MigrationToVCurrent,
                         LoginDatabaseMigrationTestBroken,
                         testing::Range(1, 4));
 
 }  // namespace password_manager