Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 2180773002: Disable broken iOS10 password manager tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/login_database_ios_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc
index bb2ea4d67b736a90680918997164a3def66082c1..4cac13d347c1d7fd600a700cd96f64490fd9fc19 100644
--- a/components/password_manager/core/browser/login_database_unittest.cc
+++ b/components/password_manager/core/browser/login_database_unittest.cc
@@ -30,6 +30,10 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "url/origin.h"
+#if defined(OS_IOS)
+#include "base/ios/ios_util.h"
+#endif
+
using autofill::PasswordForm;
using base::ASCIIToUTF16;
using ::testing::Eq;
@@ -210,6 +214,14 @@ class LoginDatabaseTest : public testing::Test {
};
TEST_F(LoginDatabaseTest, Logins) {
+#if defined(OS_IOS) && TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): This test is currently failing on the latest iOS10
+ // simulator due to a bug we expect to be fixed shortly. Temporarilly
+ // disabling the test for iOS10 simulator runs only.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
ScopedVector<autofill::PasswordForm> result;
// Verify the database is empty.
« no previous file with comments | « components/password_manager/core/browser/login_database_ios_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698