Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2175243005:
Worker: Add OWNERS to core/workers (Closed)
|
Created:
4 years, 4 months ago by nhiroki Modified:
4 years, 4 months ago CC:
chromium-reviews, abarth-chromium, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org, ikilpatrick, yhirano Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Add OWNERS to core/workers
BUG=n/a
Committed: https://crrev.com/a87f0f1544db6e2e2eca8469ff03e86c03354a28
Cr-Commit-Position: refs/heads/master@{#407788}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Worker: Add OWNERS to core/workers BUG=n/a ========== to ========== Worker: Add OWNERS to core/workers BUG=n/a ==========
nhiroki@chromium.org changed reviewers: + haraken@chromium.org, kinuko@chromium.org
Hi core/ owners, I'd like to nominate myself for an owner of core/workers. I think I have enough knowledge and experiences to take ownership. These are samples of my changes under the directory: Implemented WorkerThread graceful shutdown: - https://codereview.chromium.org/1978163002 - https://codereview.chromium.org/2011763002 - https://codereview.chromium.org/2015823002 Implemented a mechanism to detect worker thread shutdown from main thread: - https://codereview.chromium.org/2025783002 Refined/Refining the entire worker infrastructure: - https://docs.google.com/document/d/1c9XJuByGN92IqUsovR4DRap_rQSvxg1NJSItbuUnZ... - https://docs.google.com/document/d/1IWgnaDMkEZq1TSXCywE9LwxfvNgtZ9-O76JhDzWI1... - https://codereview.chromium.org/1888703002 - https://codereview.chromium.org/1897193002 Fixed crash bugs: - https://codereview.chromium.org/2041753002 - https://codereview.chromium.org/2046483002 - https://codereview.chromium.org/2075243002 Now fixing GC logic for dedicated workers: - https://codereview.chromium.org/2124693002 I'm an owner of ServiceWorker that is a big client of core/workers infrastructure: - https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/servic... - https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/modul... Please let me know if you have any questions/concerns. Thanks!
LGTM (Nit: IMHO I'm not really happy about having sub-directory owners in core/, but that's a separate discussion -- we haven't reached consensus yet.)
lgtm/2
Thank you! On 2016/07/26 10:06:44, haraken wrote: > (Nit: IMHO I'm not really happy about having sub-directory owners in core/, but > that's a separate discussion -- we haven't reached consensus yet.) Acknowledged.
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by nhiroki@chromium.org
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Worker: Add OWNERS to core/workers BUG=n/a ========== to ========== Worker: Add OWNERS to core/workers BUG=n/a ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Worker: Add OWNERS to core/workers BUG=n/a ========== to ========== Worker: Add OWNERS to core/workers BUG=n/a Committed: https://crrev.com/a87f0f1544db6e2e2eca8469ff03e86c03354a28 Cr-Commit-Position: refs/heads/master@{#407788} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a87f0f1544db6e2e2eca8469ff03e86c03354a28 Cr-Commit-Position: refs/heads/master@{#407788} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
