Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2075243002: Worker: Early return if termination is requested while worker thread is starting (Closed)

Created:
4 years, 6 months ago by nhiroki
Modified:
4 years, 6 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Early return if termination is requested while worker thread is starting WorkerThread may get ready for shutdown if termination is requested while a debugger task is running. In this case, WorkerThread disposes WorkerGlobalScope etc, so it should not resume initialization. BUG=615839 Committed: https://crrev.com/52c1c59812f930cd7056b9d6aa8c14213f2c70a9 Cr-Commit-Position: refs/heads/master@{#401543}

Patch Set 1 #

Patch Set 2 : add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 1 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
nhiroki
PTAL, thanks!
4 years, 6 months ago (2016-06-17 21:29:02 UTC) #3
kinuko
Hmm, ok. Should we have a test (in a follow-up)? lgtm anyways
4 years, 6 months ago (2016-06-20 09:16:46 UTC) #4
nhiroki
Thank you! I added a test. Can you take another look? :)
4 years, 6 months ago (2016-06-21 17:46:32 UTC) #5
nhiroki
kinuko-san, friendly ping
4 years, 6 months ago (2016-06-23 03:57:48 UTC) #6
kinuko
On 2016/06/23 03:57:48, nhiroki wrote: > kinuko-san, friendly ping still lgtm
4 years, 6 months ago (2016-06-23 04:05:58 UTC) #7
nhiroki
On 2016/06/23 04:05:58, kinuko wrote: > On 2016/06/23 03:57:48, nhiroki wrote: > > kinuko-san, friendly ...
4 years, 6 months ago (2016-06-23 04:08:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075243002/20001
4 years, 6 months ago (2016-06-23 04:08:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 05:37:55 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 05:39:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52c1c59812f930cd7056b9d6aa8c14213f2c70a9
Cr-Commit-Position: refs/heads/master@{#401543}

Powered by Google App Engine
This is Rietveld 408576698