Worker: Protect a running debugger task from forcible worker termination (2)

Worker: Protect a running debugger task from forcible worker termination (2)

A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:

1) terminate() is called while a debugger task is running. This does not
   schedule a task to forcibly terminate the worker execution.
2) terminateAndWait() is called while a debugger task is still running. This
   attempts to overtake the scheduled (actually not scheduled) termination task
   and forcibly terminates the worker execution.
3) The running debugger task is interrupted and possibly crashes.

After this change, terminateAndWait() respects the running debugger task on the
step 2).

BUG=616775
Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
Cr-Commit-Position: refs/heads/master@{#400120}

[nhiroki, 2016-06-06 11:33:22]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-06-07 01:48:56]

Patchset #3 (id:60001) has been deleted

[nhiroki, 2016-06-07 01:49:17]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-06-10 02:24:18]

Patchset #3 (id:100001) has been deleted

[nhiroki, 2016-06-10 02:24:23]

Patchset #2 (id:80001) has been deleted

[nhiroki, 2016-06-15 10:44:40]

Patchset #3 (id:140001) has been deleted

[nhiroki, 2016-06-15 11:00:15]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2016-06-15 11:01:00]

Patchset #1 (id:120001) has been deleted

[nhiroki, 2016-06-15 11:01:20]

Patchset #1 (id:160001) has been deleted

[nhiroki, 2016-06-15 12:12:14]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2016-06-15 12:12:14]

PTAL, thanks!

[kinuko, 2016-06-16 01:41:43]

lgtm

[nhiroki, 2016-06-16 07:39:07]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-06-16 07:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046483002/180001

[commit-bot: I haz the power, 2016-06-16 10:02:30]

Committed patchset #1 (id:180001)

[commit-bot: I haz the power, 2016-06-16 10:04:30]

Description was changed from

==========
Worker: Protect a running debugger task from forcible worker termination (2)

A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:

1) terminate() is called while a debugger task is running. This does not
   schedule a task to forcibly terminate the worker execution.
2) terminateAndWait() is called while a debugger task is still running. This
   attempts to overtake the scheduled (actually not scheduled) termination task
   and forcibly terminates the worker execution.
3) The running debugger task is interrupted and possibly crashes.

After this change, terminateAndWait() respects the running debugger task on the
step 2).

BUG=616775
==========

to

==========
Worker: Protect a running debugger task from forcible worker termination (2)

A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:

1) terminate() is called while a debugger task is running. This does not
   schedule a task to forcibly terminate the worker execution.
2) terminateAndWait() is called while a debugger task is still running. This
   attempts to overtake the scheduled (actually not scheduled) termination task
   and forcibly terminates the worker execution.
3) The running debugger task is interrupted and possibly crashes.

After this change, terminateAndWait() respects the running debugger task on the
step 2).

BUG=616775

Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
Cr-Commit-Position: refs/heads/master@{#400120}
==========

[commit-bot: I haz the power, 2016-06-16 10:04:31]

Patchset 1 (id:??) landed as
https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
Cr-Commit-Position: refs/heads/master@{#400120}

[Henrik Grunell, 2016-06-16 11:55:49]

A revert of this CL (patchset #1 id:180001) has been created in
https://codereview.chromium.org/2069413003/ by grunell@chromium.org.

The reason for reverting is: Two compositorworker tests have failed flakily
after the CL this CL depends on landed:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Need to revert this first..

[nhiroki, 2016-06-16 18:15:04]

Description was changed from

==========
Worker: Protect a running debugger task from forcible worker termination (2)

A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:

1) terminate() is called while a debugger task is running. This does not
   schedule a task to forcibly terminate the worker execution.
2) terminateAndWait() is called while a debugger task is still running. This
   attempts to overtake the scheduled (actually not scheduled) termination task
   and forcibly terminates the worker execution.
3) The running debugger task is interrupted and possibly crashes.

After this change, terminateAndWait() respects the running debugger task on the
step 2).

BUG=616775

Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
Cr-Commit-Position: refs/heads/master@{#400120}
==========

to

==========
Worker: Protect a running debugger task from forcible worker termination (2)

A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:

1) terminate() is called while a debugger task is running. This does not
   schedule a task to forcibly terminate the worker execution.
2) terminateAndWait() is called while a debugger task is still running. This
   attempts to overtake the scheduled (actually not scheduled) termination task
   and forcibly terminates the worker execution.
3) The running debugger task is interrupted and possibly crashes.

After this change, terminateAndWait() respects the running debugger task on the
step 2).

BUG=616775

Committed: https://crrev.com/39ce89cd7e60e2f20925eb332d9d9735185425f4
Cr-Commit-Position: refs/heads/master@{#400120}
==========