Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1897193002: Worker: Rename worker components to clarify what they work for (part 2) (Closed)

Created:
4 years, 8 months ago by nhiroki
Modified:
4 years, 8 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, falken, kinuko+worker_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Rename worker components to clarify what they work for (part 2) This CL renames WorkerObjectProxy to InProcessWorkerObjectProxy because WorkerObjectProxy works only for in-process workers (DedicatedWorker and CompositorWorker). In addition, this removes unnecessary header inclusions. Part 1: https://codereview.chromium.org/1888703002/ BUG=603785 Committed: https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2 Cr-Commit-Position: refs/heads/master@{#388194}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -274 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 5 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/workers/WorkerObjectProxy.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nhiroki
PTAL, thanks!
4 years, 8 months ago (2016-04-19 10:10:53 UTC) #5
kinuko
lgtm.
4 years, 8 months ago (2016-04-19 10:16:46 UTC) #6
haraken
LGTM
4 years, 8 months ago (2016-04-19 10:45:37 UTC) #7
nhiroki
Thank you!
4 years, 8 months ago (2016-04-19 12:52:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897193002/40001
4 years, 8 months ago (2016-04-19 12:53:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-19 12:57:19 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:58:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2
Cr-Commit-Position: refs/heads/master@{#388194}

Powered by Google App Engine
This is Rietveld 408576698