Worker: Rename worker components to clarify what they work for

Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl => DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
Committed: https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a
Cr-Commit-Position: refs/heads/master@{#388166}

[nhiroki, 2016-04-14 06:42:35]

Description was changed from

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

BUG=
==========

to

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this renames
as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy


BUG=
==========

[nhiroki, 2016-04-14 07:09:08]

Description was changed from

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this renames
as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy


BUG=
==========

to

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this patch
chanegs as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy


BUG=
==========

[nhiroki, 2016-04-14 07:11:20]

Description was changed from

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this patch
chanegs as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy


BUG=
==========

to

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this patch
chanegs as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider is used only for DedicatedWorker:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider

BUG=
==========

[nhiroki, 2016-04-14 08:21:49]

Description was changed from

==========
Worker: Rename GlobalScopeProxy to InProcessWorkerGlobelScopeProxy

  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy is
used only for DedicatedWorker and CompositorWorker. To clarify it, this patch
chanegs as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider is used only for DedicatedWorker:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider

BUG=
==========

to

==========
Worker: Rename worker components to clarify what they work for

This CL attempts to clarify which worker type each C++ class works for.

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker. They are
renamed as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it would
be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

[nhiroki, 2016-04-14 08:22:03]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-04-14 08:22:13]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-04-14 08:22:22]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

This CL attempts to clarify which worker type each C++ class works for.

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker. They are
renamed as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it would
be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

to

==========
Worker: Rename worker components to clarify what they work for

This CL attempts to clarify which worker type each C++ class works for.

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker. They are
renamed as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it would
be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

[nhiroki, 2016-04-14 08:25:24]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

This CL attempts to clarify which worker type each C++ class works for.

It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker. They are
renamed as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it would
be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
would be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

[nhiroki, 2016-04-14 08:33:39]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
would be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
would be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=to be filed
==========

[nhiroki, 2016-04-14 08:35:00]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
would be better to add "Dedicated" prefix:

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=to be filed
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=to be filed
==========

[nhiroki, 2016-04-14 08:38:15]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org, yhirano@chromium.org

[nhiroki, 2016-04-14 08:38:15]

Hi yhirano@ and kinuko@,

Can you take a look at this patch? Any feedback is welcome!

I'm thinking about renaming worker components with a more consistent naming
convention as follows:

  1.) "Worker" prefix for classes used by all worker types
  2.) "DedicatedWorker" prefix for DedicatedWorker classes
  3.) "SharedWorker" prefix for SharedWorker classes
  4.) "ServiceWorker" (or "EmbeddedWorker") prefix for ServiceWorker classes
  5.) "CompositorWorker" prefix for CompositorWorker classes
  6.) "InProcessWorker" prefix for classes used by DedicatedWorker and
CompositorWorker
  7.) "Worklet" prefix for Worklet classes

As a first step, this patch renames classes violating conventions 1, 2, 5, 6.

Thanks!

[kinuko, 2016-04-14 08:54:38]

The prefix part sgtm.

Reg: WorkerMessagingProxy renaming: the term 'worker global scope proxy' is used
so differently in InProcessWorker and ServiceWorker, I'm worrying that
introducing incomplete concept of 'worker global scope proxy' more widely by
this patch could make further refactoring tougher.

[yhirano, 2016-04-14 11:52:24]

https://codereview.chromium.org/1888703002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h
(right):

https://codereview.chromium.org/1888703002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h:52:
virtual DedicatedWorkerGlobalScopeProxy* createWorkerGlobalScopeProxy(Worker*) =
0;
createDedicatedWorkerGlobalScoprProxy?

[yhirano, 2016-04-14 11:57:00]

> Reg: WorkerMessagingProxy renaming: the term 'worker global scope proxy' is
used
> so differently in InProcessWorker and ServiceWorker, I'm worrying that
> introducing incomplete concept of 'worker global scope proxy' more widely by
> this patch could make further refactoring tougher.

They're already incompatible. I agree it's confusing but I'm not sure this CL
worsen the situation.

[kinuko, 2016-04-14 14:11:18]

On 2016/04/14 11:57:00, yhirano wrote:
> > Reg: WorkerMessagingProxy renaming: the term 'worker global scope proxy' is
> used
> > so differently in InProcessWorker and ServiceWorker, I'm worrying that
> > introducing incomplete concept of 'worker global scope proxy' more widely by
> > this patch could make further refactoring tougher.
> 
> They're already incompatible. I agree it's confusing but I'm not sure this CL
> worsen the situation.

We're changing more classes to explicitly use 'global scope proxy', which makes
me worry.

[kinuko, 2016-04-14 14:15:30]

On 2016/04/14 14:11:18, kinuko wrote:
> On 2016/04/14 11:57:00, yhirano wrote:
> > > Reg: WorkerMessagingProxy renaming: the term 'worker global scope proxy'
is
> > used
> > > so differently in InProcessWorker and ServiceWorker, I'm worrying that
> > > introducing incomplete concept of 'worker global scope proxy' more widely
by
> > > this patch could make further refactoring tougher.
> > 
> > They're already incompatible. I agree it's confusing but I'm not sure this
CL
> > worsen the situation.
> 
> We're changing more classes to explicitly use 'global scope proxy', which
makes
> me worry.

Say, we could instead just remove WorkerGlobalScopeProxy base class and rename
WorkerMessagingProxy to use InProcessWorkerMessagingProxy etc.

[nhiroki, 2016-04-15 01:23:10]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=to be filed
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

[nhiroki, 2016-04-15 09:50:56]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerGlobalScopeProxy
  DedicatedWorkerMessageingProxy => DedicatedWorkerGlobalScopeProxy
  CompositorWorkerMessagingProxy => CompositorWorkerGlobalScopeProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated". In addition, it should be renamed to
MessagingProxyProvider in favor of (1):

  WorkerGlobalScopeProxyProvider => DedicatedWorkerMessagingProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerMessagingProxyProviderImpl

BUG=603785
==========

[nhiroki, 2016-04-19 01:54:24]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => (merged into InProcessWorkerGlobalScopeProxy)
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated". In addition, it should be renamed to
MessagingProxyProvider in favor of (1):

  WorkerGlobalScopeProxyProvider => DedicatedWorkerMessagingProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerMessagingProxyProviderImpl

BUG=603785
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

[nhiroki, 2016-04-19 02:07:15]

On 2016/04/14 14:15:30, kinuko wrote:
> On 2016/04/14 14:11:18, kinuko wrote:
> > On 2016/04/14 11:57:00, yhirano wrote:
> > > > Reg: WorkerMessagingProxy renaming: the term 'worker global scope proxy'
> is
> > > used
> > > > so differently in InProcessWorker and ServiceWorker, I'm worrying that
> > > > introducing incomplete concept of 'worker global scope proxy' more
widely
> by
> > > > this patch could make further refactoring tougher.
> > > 
> > > They're already incompatible. I agree it's confusing but I'm not sure this
> CL
> > > worsen the situation.
> > 
> > We're changing more classes to explicitly use 'global scope proxy', which
> makes
> > me worry.
> 
> Say, we could instead just remove WorkerGlobalScopeProxy base class and rename
> WorkerMessagingProxy to use InProcessWorkerMessagingProxy etc.

Thank you for your comments! 

Hmm... naming convention around GlobalScopeProxy/MessagingProxy seems to need
more comprehensive discussion. For now, let me drop changes around
GlobalScopeProxy/MessagingProxy and make this CL focus on adding
Dedicated/InProcess prefixes. I'll write a design doc about it later.

Thanks!

[nhiroki, 2016-04-19 02:09:23]

https://codereview.chromium.org/1888703002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h
(right):

https://codereview.chromium.org/1888703002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h:52:
virtual DedicatedWorkerGlobalScopeProxy* createWorkerGlobalScopeProxy(Worker*) =
0;
On 2016/04/14 11:52:24, yhirano wrote:
> createDedicatedWorkerGlobalScoprProxy?

Done.

[kinuko, 2016-04-19 04:44:20]

renaming looks good

> WorkerMessagingProxy => InProcessWorkerMessagingProxy

So we're not making this change as we're not yet sure about the MessagingProxy /
GSProxy naming?  If so please remove this from the description (and let's add
TODO comment to WorkerMessagingProxy to note that this needs to be renamed to
InProcessWorker something)

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
(right):

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h:52:
InProcessWorkerGlobalScopeProxy* createDedicatedWorkerGlobalScopeProxy(Worker*)
override;
nit: createDedicatedWorkerGSP returning InProcessWorkerGSP feels slightly weird,
while it's probably ok...

[yhirano, 2016-04-19 04:50:28]

lgtm

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/Worker.h (right):

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/Worker.h:13: class ExecutionContext;
+class InProcessWorkerGlobalScopeProxy;

[nhiroki, 2016-04-19 04:53:24]

Thanks. Comment reply only.

On 2016/04/19 04:44:20, kinuko wrote:
> renaming looks good
> 
> > WorkerMessagingProxy => InProcessWorkerMessagingProxy
> 
> So we're not making this change as we're not yet sure about the MessagingProxy
/
> GSProxy naming?  If so please remove this from the description (and let's add
> TODO comment to WorkerMessagingProxy to note that this needs to be renamed to
> InProcessWorker something)

Oh... I meant to rename WorkerMessagingProxy to InProcessWorkerMessagingProxy in
the patchset 6. I'll make a new patchset renaming it soon.

[haraken, 2016-04-19 05:00:30]

LGTM

[nhiroki, 2016-04-19 05:28:20]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames/changes them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

[nhiroki, 2016-04-19 06:15:05]

Thank you for reviewing! Updated.

kinuko@, can you take another look?

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/Worker.h (right):

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/Worker.h:13: class ExecutionContext;
On 2016/04/19 04:50:28, yhirano wrote:
> +class InProcessWorkerGlobalScopeProxy;

Done.

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
(right):

https://codereview.chromium.org/1888703002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h:52:
InProcessWorkerGlobalScopeProxy* createDedicatedWorkerGlobalScopeProxy(Worker*)
override;
On 2016/04/19 04:44:20, kinuko wrote:
> nit: createDedicatedWorkerGSP returning InProcessWorkerGSP feels slightly
weird,
> while it's probably ok...

Agreed. I come up with 2 options here:

  a.) Returns "DedicatedWorkerMessagingProxy" instead of
"InProcessWorkerGlobalScopeProxy".
  b.) Revert the function name change, that is, "createWorkerGlobalScopeProxy".

The option (a) looks also weird because the type of return value does not match
with the class and function names. The option (b) looks more natural than the
current patch and the option a.), so I chose the option (b). I hope that the
following CLs can fix this twisted naming...

Done.

[nhiroki, 2016-04-19 06:15:43]

On 2016/04/19 04:53:24, nhiroki wrote:
> Thanks. Comment reply only.
> 
> On 2016/04/19 04:44:20, kinuko wrote:
> > renaming looks good
> > 
> > > WorkerMessagingProxy => InProcessWorkerMessagingProxy
> > 
> > So we're not making this change as we're not yet sure about the
MessagingProxy
> /
> > GSProxy naming?  If so please remove this from the description (and let's
add
> > TODO comment to WorkerMessagingProxy to note that this needs to be renamed
to
> > InProcessWorker something)
> 
> Oh... I meant to rename WorkerMessagingProxy to InProcessWorkerMessagingProxy
in
> the patchset 6. I'll make a new patchset renaming it soon.

Renamed the proxy and added a TODO comment.

[kinuko, 2016-04-19 06:29:03]

you forgot to add new files?

https://codereview.chromium.org/1888703002/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerObjectProxy.h (right):

https://codereview.chromium.org/1888703002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerObjectProxy.h:54: class CORE_EXPORT
WorkerObjectProxy : public WorkerReportingProxy {
no need to change this in this CL, but this one seems to be also only used by
in-process workers

[nhiroki, 2016-04-19 07:04:21]

On 2016/04/19 06:29:03, kinuko wrote:
> you forgot to add new files?

Ohh..., sorry! I added missing files.

>
https://codereview.chromium.org/1888703002/diff/180001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/workers/WorkerObjectProxy.h (right):
> 
>
https://codereview.chromium.org/1888703002/diff/180001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/workers/WorkerObjectProxy.h:54: class
CORE_EXPORT
> WorkerObjectProxy : public WorkerReportingProxy {
> no need to change this in this CL, but this one seems to be also only used by
> in-process workers

I'll work on it after this CL :)

[kinuko, 2016-04-19 08:04:29]

lgtm, thanks!

[nhiroki, 2016-04-19 08:07:34]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-04-19 08:07:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1888703002/#ps200001
(title: "add missing files")

[commit-bot: I haz the power, 2016-04-19 08:07:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888703002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888703002/200001

[commit-bot: I haz the power, 2016-04-19 08:16:49]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

[commit-bot: I haz the power, 2016-04-19 08:16:50]

Committed patchset #9 (id:200001)

[commit-bot: I haz the power, 2016-04-19 08:18:25]

Description was changed from

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785
==========

to

==========
Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl =>
DedicatedWorkerGlobalScopeProxyProviderImpl

BUG=603785

Committed: https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a
Cr-Commit-Position: refs/heads/master@{#388166}
==========

[commit-bot: I haz the power, 2016-04-19 08:18:26]

Patchset 9 (id:??) landed as
https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a
Cr-Commit-Position: refs/heads/master@{#388166}