chrome/browser/password_manager: Change auto to not deduce raw pointers.

chrome/browser/password_manager: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=vabr@chromium.org
BUG=554600
Committed: https://crrev.com/6bcf17c7e6c8a5968a63a9d761d2dda7ecfbbe39
Cr-Commit-Position: refs/heads/master@{#407614}

[vmpstr, 2016-07-22 00:52:38]

Please take a look.

[vabr (Chromium), 2016-07-22 07:18:50]

Thanks, LGTM!

The necessity to use auto*& when modifying ScopedVector, and the easiness of
missing that, gives me one more good reason to finally migrate to
vector<unique_ptr> in password_manager.

Cheers,
Vaclav

[vabr (Chromium), 2016-07-22 07:18:57]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 07:19:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 07:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 07:49:11]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2016-07-25 21:12:21]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-07-25 21:12:46]

On 2016/07/22 07:18:50, vabr (Chromium) wrote:
> Thanks, LGTM!
> 
> The necessity to use auto*& when modifying ScopedVector, and the easiness of
> missing that, gives me one more good reason to finally migrate to
> vector<unique_ptr> in password_manager.

Nice :) that's a good thing!

> 
> Cheers,
> Vaclav

[commit-bot: I haz the power, 2016-07-25 21:13:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:13:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 22:15:47]

Description was changed from

==========
chrome/browser/password_manager: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=vabr@chromium.org
BUG=554600
==========

to

==========
chrome/browser/password_manager: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=vabr@chromium.org
BUG=554600

Committed: https://crrev.com/6bcf17c7e6c8a5968a63a9d761d2dda7ecfbbe39
Cr-Commit-Position: refs/heads/master@{#407614}
==========

[commit-bot: I haz the power, 2016-07-25 22:15:48]

Patchset 1 (id:??) landed as
https://crrev.com/6bcf17c7e6c8a5968a63a9d761d2dda7ecfbbe39
Cr-Commit-Position: refs/heads/master@{#407614}