chrome/browser/password_manager/native_backend_libsecret.cc - Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index 899e77d5dd6fa2cb3067ebcfe0a858d358ef4806..f31f3d1e2d3f1b31da2d2f63951cf7b3d565c4b9 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -287,7 +287,7 @@ bool NativeBackendLibsecret::DisableAutoSignInForOrigins(

if (!GetLoginsList(nullptr, ALL_LOGINS, &all_forms))

return false;

- for (auto& form : all_forms) {

+ for (auto* form : all_forms) {

if (origin_filter.Run(form->origin) && !form->skip_zero_click) {

form->skip_zero_click = true;

if (!UpdateLogin(*form, changes))

@@ -469,7 +469,7 @@ bool NativeBackendLibsecret::GetLoginsBetween(

date_to_compare == CREATION_TIMESTAMP

? &autofill::PasswordForm::date_created

: &autofill::PasswordForm::date_synced;

- for (auto& saved_form : all_forms) {

+ for (auto*& saved_form : all_forms) {

if (get_begin <= saved_form->*date_member &&

(get_end.is_null() || saved_form->*date_member < get_end)) {

forms->push_back(saved_form);