Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 3002 matching lines...) Expand 10 before | Expand all | Expand 10 after
3013 content::WebContents::CreateParams(WebContents()->GetBrowserContext()))); 3013 content::WebContents::CreateParams(WebContents()->GetBrowserContext())));
3014 NavigationObserver observer(detached_web_contents.get()); 3014 NavigationObserver observer(detached_web_contents.get());
3015 detached_web_contents->GetController().LoadURL( 3015 detached_web_contents->GetController().LoadURL(
3016 embedded_test_server()->GetURL("/password/multi_frames.html"), 3016 embedded_test_server()->GetURL("/password/multi_frames.html"),
3017 content::Referrer(), ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string()); 3017 content::Referrer(), ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string());
3018 observer.Wait(); 3018 observer.Wait();
3019 // Ensure that there is at least one more frame created than just the main 3019 // Ensure that there is at least one more frame created than just the main
3020 // frame. 3020 // frame.
3021 EXPECT_LT(1u, detached_web_contents->GetAllFrames().size()); 3021 EXPECT_LT(1u, detached_web_contents->GetAllFrames().size());
3022 3022
3023 auto tab_strip_model = browser()->tab_strip_model(); 3023 auto* tab_strip_model = browser()->tab_strip_model();
3024 // Check that the autofill and password manager driver factories are notified 3024 // Check that the autofill and password manager driver factories are notified
3025 // about all frames, not just the main one. The factories should receive 3025 // about all frames, not just the main one. The factories should receive
3026 // messages for non-main frames, in particular 3026 // messages for non-main frames, in particular
3027 // AutofillHostMsg_PasswordFormsParsed. If that were the first time the 3027 // AutofillHostMsg_PasswordFormsParsed. If that were the first time the
3028 // factories hear about such frames, this would crash. 3028 // factories hear about such frames, this would crash.
3029 tab_strip_model->AddWebContents(detached_web_contents.release(), -1, 3029 tab_strip_model->AddWebContents(detached_web_contents.release(), -1,
3030 ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL, 3030 ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
3031 TabStripModel::ADD_ACTIVE); 3031 TabStripModel::ADD_ACTIVE);
3032 } 3032 }
3033 3033
3034 } // namespace password_manager 3034 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698