Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index aa3cd3de0f62f3377e5f21842252079bec7397ef..5f27e2f50a7694238ab251bd787fe178602bb4a2 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -41,7 +41,7 @@ void AddElementsToJavaCredentialArray(
password_manager::CredentialType type,
int indexStart = 0) {
int index = indexStart;
- for (auto password_form : password_forms) {
+ for (auto* password_form : password_forms) {
ScopedJavaLocalRef<jobject> java_credential = CreateNativeCredential(
env, *password_form, index - indexStart, static_cast<int>(type));
env->SetObjectArrayElement(java_credentials_array.obj(), index,
@@ -93,11 +93,11 @@ void FetchAvatars(
const std::vector<const autofill::PasswordForm*>& password_forms,
int index,
net::URLRequestContextGetter* request_context) {
- for (auto password_form : password_forms) {
+ for (auto* password_form : password_forms) {
if (!password_form->icon_url.is_valid())
continue;
// Fetcher deletes itself once fetching is finished.
- auto fetcher =
+ auto* fetcher =
new AvatarFetcherAndroid(password_form->icon_url, index, java_dialog);
fetcher->Start(request_context);
++index;
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698