chrome/browser/password_manager/native_backend_gnome_x.cc - Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/account_chooser_dialog_android.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_gnome_x.cc

diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc

index dad1caf025c8c58e3c4a2baf6d5e667a7ac3768f..5c1118cde6bf84d7cb6bbb57595a69d6659a29a4 100644

--- a/chrome/browser/password_manager/native_backend_gnome_x.cc

+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc

@@ -706,7 +706,7 @@ bool NativeBackendGnome::DisableAutoSignInForOrigins(

if (!GetAllLogins(&forms))

return false;

- for (auto& form : forms) {

+ for (auto* form : forms) {

if (origin_filter.Run(form->origin) && !form->skip_zero_click) {

form->skip_zero_click = true;

if (!UpdateLogin(*form, changes))

@@ -816,7 +816,7 @@ bool NativeBackendGnome::GetLoginsBetween(base::Time get_begin,

base::Time PasswordForm::*date_member = date_to_compare == CREATION_TIMESTAMP

? &PasswordForm::date_created

: &PasswordForm::date_synced;

- for (auto& saved_form : all_forms) {

+ for (auto*& saved_form : all_forms) {

if (get_begin <= saved_form->*date_member &&

(get_end.is_null() || saved_form->*date_member < get_end)) {

forms->push_back(saved_form);