Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7160)

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.cc

Issue 2169263002: chrome/browser/password_manager: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_kwallet_x.cc
diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.cc b/chrome/browser/password_manager/native_backend_kwallet_x.cc
index 066f625d0331f548887a9223ffe1053e523349df..a383723d0df157ca18602282b43a47c48fb41235 100644
--- a/chrome/browser/password_manager/native_backend_kwallet_x.cc
+++ b/chrome/browser/password_manager/native_backend_kwallet_x.cc
@@ -478,7 +478,7 @@ bool NativeBackendKWallet::RemoveLogin(
ScopedVector<autofill::PasswordForm> kept_forms;
kept_forms.reserve(all_forms.size());
- for (auto& saved_form : all_forms) {
+ for (auto*& saved_form : all_forms) {
if (!ArePasswordFormUniqueKeyEqual(form, *saved_form)) {
kept_forms.push_back(saved_form);
saved_form = nullptr;
@@ -516,7 +516,7 @@ bool NativeBackendKWallet::DisableAutoSignInForOrigins(
if (!GetAllLogins(&all_forms))
return false;
- for (auto& form : all_forms) {
+ for (auto* form : all_forms) {
if (origin_filter.Run(form->origin) && !form->skip_zero_click) {
form->skip_zero_click = true;
if (!UpdateLogin(*form, changes))
@@ -630,7 +630,7 @@ bool NativeBackendKWallet::GetLoginsList(
}
// We have to read all the entries, and then filter them here.
forms->reserve(all_forms.size());
- for (auto& saved_form : all_forms) {
+ for (auto*& saved_form : all_forms) {
if (saved_form->blacklisted_by_user ==
(options == BlacklistOptions::BLACKLISTED)) {
forms->push_back(saved_form);
@@ -742,7 +742,7 @@ bool NativeBackendKWallet::RemoveLoginsBetween(
date_to_compare == CREATION_TIMESTAMP
? &autofill::PasswordForm::date_created
: &autofill::PasswordForm::date_synced;
- for (auto& saved_form : all_forms) {
+ for (auto*& saved_form : all_forms) {
if (delete_begin <= saved_form->*date_member &&
(delete_end.is_null() || saved_form->*date_member < delete_end)) {
changes->push_back(password_manager::PasswordStoreChange(
« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698