Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed)

Created:
6 years, 9 months ago by Jeffrey Yasskin
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, felt, Greg Billock, plundblad+watch_chromium.org, tzik, aboxhall+watch_chromium.org, miu+watch_chromium.org, yuzo+watch_chromium.org, robertshield+watch_chromium.org, nhiroki, benjhayden+dwatch_chromium.org, gab+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, kinuko+watch, erikwright+watch_chromium.org, Lei Zhang, tommycli
Visibility:
Public.

Description

Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. This is a follow-up to https://src.chromium.org/viewvc/chrome?revision=256913&view=revision that makes error messages more descriptive. It was automatically produced with git grep -l 'DCHECK(.*CurrentlyOn' extensions chrome/*/extensions|xargs sed -i -e 's/DCHECK(BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' -e 's/DCHECK(content::BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -519 lines) Patch
M chrome/browser/extensions/activity_log/activity_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/audio/audio_service_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_cache_delegate.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/dns/mock_host_resolver_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 24 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_nonchromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_manager.cc View 18 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_service_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_connection.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_event_dispatcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_processor.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/sync_storage_backend.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_value_store_cache.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_network/system_network_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_storage/storage_info_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/blacklist.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/blacklist_state_fetcher.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/blob_reader.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_renderer_state.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_warning_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_warning_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/requirements_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/safe_manifest_parser.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/api_resource_manager.h View 6 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/async_api_function.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/dns/dns_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/info_map.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jeffrey Yasskin
jam suggested I TBR these CLs, but I'm sending the first couple to owners as ...
6 years, 9 months ago (2014-03-28 06:59:12 UTC) #1
Yoyo Zhou
spot checked and LGTM
6 years, 9 months ago (2014-03-28 20:40:38 UTC) #2
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-28 20:41:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216513002/1
6 years, 9 months ago (2014-03-28 20:44:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 23:45:16 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 23:45:16 UTC) #6
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-29 00:45:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216513002/1
6 years, 9 months ago (2014-03-29 00:47:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 02:01:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290794
6 years, 9 months ago (2014-03-29 02:01:04 UTC) #10
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 9 months ago (2014-03-29 05:44:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/216513002/1
6 years, 9 months ago (2014-03-29 05:44:13 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:37:29 UTC) #13
Message was sent while issue was closed.
Change committed as 260380

Powered by Google App Engine
This is Rietveld 408576698