chrome/browser/extensions/api/web_request/web_request_api.cc - Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc

index 8b84b2dcafd5686745bf353de2d12d6938284001..2b98bd762e2780ec630bf6f35c7e8a5ece049c42 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc

@@ -345,7 +345,7 @@ void RemoveEventListenerOnUI(

const std::string& event_name,

int process_id,

const std::string& extension_id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

Profile* profile = reinterpret_cast<Profile*>(profile_id);

if (!g_browser_process->profile_manager()->IsValidProfile(profile))

@@ -371,7 +371,7 @@ void SendOnMessageEventOnUI(

void* profile_id,

const std::string& extension_id,

scoped_ptr<base::DictionaryValue> event_argument) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

Profile* profile = reinterpret_cast<Profile*>(profile_id);

if (!g_browser_process->profile_manager()->IsValidProfile(profile))

@@ -433,7 +433,7 @@ WebRequestAPI::GetFactoryInstance() {

}

void WebRequestAPI::OnListenerRemoved(const EventListenerInfo& details) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Note that details.event_name includes the sub-event details (e.g. "/123").

BrowserThread::PostTask(BrowserThread::IO,

FROM_HERE,