chrome/browser/extensions/api/music_manager_private/device_id.cc - Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/music_manager_private/device_id.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher.cc ('k') | chrome/browser/extensions/api/music_manager_private/device_id_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/music_manager_private/device_id.cc

diff --git a/chrome/browser/extensions/api/music_manager_private/device_id.cc b/chrome/browser/extensions/api/music_manager_private/device_id.cc

index 1bc87f5eae76ea2dc51c34a2934d36c569d95489..880d72274e67e96ffaf0f854607d1fcec92fe23c 100644

--- a/chrome/browser/extensions/api/music_manager_private/device_id.cc

+++ b/chrome/browser/extensions/api/music_manager_private/device_id.cc

@@ -33,7 +33,7 @@ bool ComputeHmacSha256(const std::string& key,

void GetRawDeviceIdCallback(const std::string& extension_id,

const DeviceId::IdCallback& callback,

const std::string& raw_device_id) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (raw_device_id.empty()) {

callback.Run("");

@@ -179,7 +179,7 @@ namespace api {

// static

void DeviceId::GetDeviceId(const std::string& extension_id,

const IdCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

CHECK(!extension_id.empty());

// Forward call to platform specific implementation, then compute the HMAC