chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc - Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chrome/browser/extensions/blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

index 010002798b413bc8ec06340f5fa65239edda3422..6ea11635459aa571cd3b579b28774c8f91eb5b15 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

@@ -94,7 +94,7 @@ bool WebrtcLoggingPrivateSetMetaDataFunction::RunImpl() {

void WebrtcLoggingPrivateSetMetaDataFunction::SetMetaDataCallback(

bool success, const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!success)

SetError(error_message);

SendResponse(success);

@@ -128,7 +128,7 @@ bool WebrtcLoggingPrivateStartFunction::RunImpl() {

void WebrtcLoggingPrivateStartFunction::StartCallback(

bool success, const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!success)

SetError(error_message);

SendResponse(success);

@@ -187,7 +187,7 @@ bool WebrtcLoggingPrivateStopFunction::RunImpl() {

void WebrtcLoggingPrivateStopFunction::StopCallback(

bool success, const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!success)

SetError(error_message);

SendResponse(success);

@@ -222,7 +222,7 @@ bool WebrtcLoggingPrivateUploadFunction::RunImpl() {

void WebrtcLoggingPrivateUploadFunction::UploadCallback(

bool success, const std::string& report_id,

const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (success) {

api::webrtc_logging_private::UploadResult result;

result.report_id = report_id;

@@ -261,7 +261,7 @@ bool WebrtcLoggingPrivateDiscardFunction::RunImpl() {

void WebrtcLoggingPrivateDiscardFunction::DiscardCallback(

bool success, const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!success)

SetError(error_message);

SendResponse(success);