chrome/browser/extensions/api/networking_private/networking_private_service_client.cc - Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc b/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

index 6865dcd925c587429cbb940b1f129cfa1054f783..fb65df355c85c11a4148f02184288010ca29c0e6 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client.cc

@@ -186,7 +186,7 @@ NetworkingPrivateServiceClient::ServiceCallbacks::ServiceCallbacks() {}

NetworkingPrivateServiceClient::ServiceCallbacks::~ServiceCallbacks() {}

void NetworkingPrivateServiceClient::Shutdown() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);

// Clear callbacks map to release callbacks from UI thread.

callbacks_map_.Clear();

@@ -615,7 +615,7 @@ void NetworkingPrivateServiceClient::AfterVerifyAndEncryptCredentials(

ServiceCallbacksID callback_id,

const std::string& encrypted_data,

const std::string& error) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

ServiceCallbacks* service_callbacks = callbacks_map_.Lookup(callback_id);

DCHECK(service_callbacks);

if (!error.empty()) {

@@ -648,7 +648,7 @@ void NetworkingPrivateServiceClient::AfterVerifyAndEncryptData(

void NetworkingPrivateServiceClient::OnNetworksChangedEventOnUIThread(

const std::vector<std::string>& network_guids) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

FOR_EACH_OBSERVER(Observer,

network_events_observers_,

OnNetworksChangedEvent(network_guids));

@@ -656,7 +656,7 @@ void NetworkingPrivateServiceClient::OnNetworksChangedEventOnUIThread(

void NetworkingPrivateServiceClient::OnNetworkListChangedEventOnUIThread(

const std::vector<std::string>& network_guids) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

FOR_EACH_OBSERVER(Observer,

network_events_observers_,

OnNetworkListChangedEvent(network_guids));