chrome/browser/extensions/api/serial/serial_event_dispatcher.cc - Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_event_dispatcher.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/serial/serial_connection.cc ('k') | chrome/browser/extensions/api/storage/managed_value_store_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/serial/serial_event_dispatcher.cc

diff --git a/chrome/browser/extensions/api/serial/serial_event_dispatcher.cc b/chrome/browser/extensions/api/serial/serial_event_dispatcher.cc

index 06bbf8b4c0a0bb66d4cfec5d9b8b73fa9b9c3b31..dc93796a2b47995b2f8d4c3a58bffabf0c12b3bd 100644

--- a/chrome/browser/extensions/api/serial/serial_event_dispatcher.cc

+++ b/chrome/browser/extensions/api/serial/serial_event_dispatcher.cc

@@ -57,7 +57,7 @@ SerialEventDispatcher::ReceiveParams::~ReceiveParams() {}

void SerialEventDispatcher::PollConnection(const std::string& extension_id,

int connection_id) {

- DCHECK(BrowserThread::CurrentlyOn(thread_id_));

+ DCHECK_CURRENTLY_ON(thread_id_);

ReceiveParams params;

params.thread_id = thread_id_;

@@ -71,7 +71,7 @@ void SerialEventDispatcher::PollConnection(const std::string& extension_id,

// static

void SerialEventDispatcher::StartReceive(const ReceiveParams& params) {

- DCHECK(BrowserThread::CurrentlyOn(params.thread_id));

+ DCHECK_CURRENTLY_ON(params.thread_id);

SerialConnection* connection =

params.connections->Get(params.extension_id, params.connection_id);

@@ -89,7 +89,7 @@ void SerialEventDispatcher::StartReceive(const ReceiveParams& params) {

void SerialEventDispatcher::ReceiveCallback(const ReceiveParams& params,

const std::string& data,

serial::ReceiveError error) {

- DCHECK(BrowserThread::CurrentlyOn(params.thread_id));

+ DCHECK_CURRENTLY_ON(params.thread_id);

// Note that an error (e.g. timeout) does not necessarily mean that no data

// was read, so we may fire an onReceive regardless of any error code.

@@ -129,7 +129,7 @@ void SerialEventDispatcher::ReceiveCallback(const ReceiveParams& params,

// static

void SerialEventDispatcher::PostEvent(const ReceiveParams& params,

scoped_ptr<extensions::Event> event) {

- DCHECK(BrowserThread::CurrentlyOn(params.thread_id));

+ DCHECK_CURRENTLY_ON(params.thread_id);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

@@ -143,7 +143,7 @@ void SerialEventDispatcher::PostEvent(const ReceiveParams& params,

void SerialEventDispatcher::DispatchEvent(void* profile_id,

const std::string& extension_id,

scoped_ptr<extensions::Event> event) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

Profile* profile = reinterpret_cast<Profile*>(profile_id);

if (!g_browser_process->profile_manager()->IsValidProfile(profile))