Change ChooserController::Observer to ChooserController::View

Change ChooserController::Observer to ChooserController::View

Based on the comment from:
https://codereview.chromium.org/2155743002/

This CL changes ChooserController::Observer to ChooserController::View
to better reflect its purpose, since ChooserController needs to update
its view when necessary.

BUG=629878
Committed: https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1
Cr-Commit-Position: refs/heads/master@{#406696}

[juncai, 2016-07-20 17:55:08]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-20 18:08:01]

juncai@chromium.org changed reviewers:
+ msw@chromium.org, reillyg@chromium.org, scheib@chromium.org

[juncai, 2016-07-20 18:08:02]

msw@chromium.org, please review change in:
//chrome/browser/ui/views/
//chrome/browser/ui/cocoa/

reillyg@chromium.org, please review change in:
//chrome/browser/chooser_controller/
//chrome/browser/usb/

scheib@chromium.org, please review change in:
//chrome/browser/ui/bluetooth/

[commit-bot: I haz the power, 2016-07-20 18:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:49:26]

Dry run: This issue passed the CQ dry run.

[msw, 2016-07-20 20:37:07]

lgtm with nits

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/chooser_cont...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/chooser_cont...
chrome/browser/chooser_controller/chooser_controller.h:30: // implementation
should register a view.
nit: "a view to observe changes"

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/ui/bluetooth...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/ui/bluetooth...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:110: if (view())
nit: for each of these multi-line conditional blocks; please add curly braces,
or change the comment pattern to something like:
  // Notify the view that the Bluetooth adapter is turned off.
  if (view())
    view()->OnAdapterEnabledChanged(false);
(or just remove the comments; the code is fairly self-evident)

[scheib, 2016-07-20 20:54:53]

LGTM, thanks.

[Reilly Grant (use Gerrit), 2016-07-20 20:57:03]

lgtm

[juncai, 2016-07-20 21:19:55]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:20:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:15:48]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-07-20 22:24:30]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-07-20 22:24:31]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
reillyg@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2163683005/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-07-20 22:25:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:31:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 22:34:52]

Description was changed from

==========
Change ChooserController::Observer to ChooserController::View

Based on the comment from:
https://codereview.chromium.org/2155743002/

This CL changes ChooserController::Observer to ChooserController::View
to better reflect its purpose, since ChooserController needs to update
its view when necessary.

BUG=629878
==========

to

==========
Change ChooserController::Observer to ChooserController::View

Based on the comment from:
https://codereview.chromium.org/2155743002/

This CL changes ChooserController::Observer to ChooserController::View
to better reflect its purpose, since ChooserController needs to update
its view when necessary.

BUG=629878

Committed: https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1
Cr-Commit-Position: refs/heads/master@{#406696}
==========

[commit-bot: I haz the power, 2016-07-20 22:34:53]

Patchset 2 (id:??) landed as
https://crrev.com/796733012dd7fe6edf6e5360087447f3a2d187e1
Cr-Commit-Position: refs/heads/master@{#406696}

[juncai, 2016-07-20 22:37:45]

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/chooser_cont...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/chooser_cont...
chrome/browser/chooser_controller/chooser_controller.h:30: // implementation
should register a view.
On 2016/07/20 20:37:07, msw wrote:
> nit: "a view to observe changes"

Done.

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/ui/bluetooth...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2163683005/diff/1/chrome/browser/ui/bluetooth...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:110: if (view())
On 2016/07/20 20:37:07, msw wrote:
> nit: for each of these multi-line conditional blocks; please add curly braces,
> or change the comment pattern to something like:
>   // Notify the view that the Bluetooth adapter is turned off.
>   if (view())
>     view()->OnAdapterEnabledChanged(false);
> (or just remove the comments; the code is fairly self-evident)

Done.