Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

Issue 2163683005: Change ChooserController::Observer to ChooserController::View (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h" 5 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 22 matching lines...) Expand all
33 const CGFloat kVerticalPadding = 10.0f; 33 const CGFloat kVerticalPadding = 10.0f;
34 34
35 // Separator alpha value. 35 // Separator alpha value.
36 const CGFloat kSeparatorAlphaValue = 0.6f; 36 const CGFloat kSeparatorAlphaValue = 0.6f;
37 37
38 // Separator height. 38 // Separator height.
39 const CGFloat kSeparatorHeight = 1.0f; 39 const CGFloat kSeparatorHeight = 1.0f;
40 40
41 } // namespace 41 } // namespace
42 42
43 class TableViewController : public ChooserController::Observer { 43 class TableViewController : public ChooserController::View {
44 public: 44 public:
45 TableViewController(ChooserController* chooser_controller, 45 TableViewController(ChooserController* chooser_controller,
46 NSTableView* table_view); 46 NSTableView* table_view);
47 ~TableViewController() override; 47 ~TableViewController() override;
48 48
49 // ChooserController::Observer: 49 // ChooserController::View:
50 void OnOptionsInitialized() override; 50 void OnOptionsInitialized() override;
51 void OnOptionAdded(size_t index) override; 51 void OnOptionAdded(size_t index) override;
52 void OnOptionRemoved(size_t index) override; 52 void OnOptionRemoved(size_t index) override;
53 void OnAdapterEnabledChanged(bool enabled) override; 53 void OnAdapterEnabledChanged(bool enabled) override;
54 void OnRefreshStateChanged(bool refreshing) override; 54 void OnRefreshStateChanged(bool refreshing) override;
55 55
56 void UpdateTableView(); 56 void UpdateTableView();
57 57
58 private: 58 private:
59 ChooserController* chooser_controller_; 59 ChooserController* chooser_controller_;
60 NSTableView* table_view_; 60 NSTableView* table_view_;
61 61
62 DISALLOW_COPY_AND_ASSIGN(TableViewController); 62 DISALLOW_COPY_AND_ASSIGN(TableViewController);
63 }; 63 };
64 64
65 TableViewController::TableViewController(ChooserController* chooser_controller, 65 TableViewController::TableViewController(ChooserController* chooser_controller,
66 NSTableView* table_view) 66 NSTableView* table_view)
67 : chooser_controller_(chooser_controller), table_view_(table_view) { 67 : chooser_controller_(chooser_controller), table_view_(table_view) {
68 DCHECK(chooser_controller_); 68 DCHECK(chooser_controller_);
69 DCHECK(table_view_); 69 DCHECK(table_view_);
70 chooser_controller_->set_observer(this); 70 chooser_controller_->set_view(this);
71 } 71 }
72 72
73 TableViewController::~TableViewController() { 73 TableViewController::~TableViewController() {
74 chooser_controller_->set_observer(nullptr); 74 chooser_controller_->set_view(nullptr);
75 } 75 }
76 76
77 void TableViewController::OnOptionsInitialized() { 77 void TableViewController::OnOptionsInitialized() {
78 UpdateTableView(); 78 UpdateTableView();
79 } 79 }
80 80
81 void TableViewController::OnOptionAdded(size_t index) { 81 void TableViewController::OnOptionAdded(size_t index) {
82 UpdateTableView(); 82 UpdateTableView();
83 } 83 }
84 84
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 367
368 - (void)close { 368 - (void)close {
369 chooserController_->Close(); 369 chooserController_->Close();
370 } 370 }
371 371
372 - (void)onHelpPressed:(id)sender { 372 - (void)onHelpPressed:(id)sender {
373 chooserController_->OpenHelpCenterUrl(); 373 chooserController_->OpenHelpCenterUrl();
374 } 374 }
375 375
376 @end 376 @end
OLDNEW
« no previous file with comments | « chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('k') | chrome/browser/ui/views/chooser_content_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698