Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Side by Side Diff: chrome/browser/ui/views/chooser_content_view.cc

Issue 2163683005: Change ChooserController::Observer to ChooserController::View (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/chooser_content_view.h" 5 #include "chrome/browser/ui/views/chooser_content_view.h"
6 6
7 #include "chrome/grit/generated_resources.h" 7 #include "chrome/grit/generated_resources.h"
8 #include "ui/base/l10n/l10n_util.h" 8 #include "ui/base/l10n/l10n_util.h"
9 #include "ui/views/controls/link.h" 9 #include "ui/views/controls/link.h"
10 #include "ui/views/controls/styled_label.h" 10 #include "ui/views/controls/styled_label.h"
11 #include "ui/views/controls/table/table_view.h" 11 #include "ui/views/controls/table/table_view.h"
12 #include "ui/views/controls/throbber.h" 12 #include "ui/views/controls/throbber.h"
13 #include "ui/views/layout/fill_layout.h" 13 #include "ui/views/layout/fill_layout.h"
14 14
15 namespace { 15 namespace {
16 16
17 const int kChooserWidth = 330; 17 const int kChooserWidth = 330;
18 18
19 const int kChooserHeight = 220; 19 const int kChooserHeight = 220;
20 20
21 const int kThrobberDiameter = 50; 21 const int kThrobberDiameter = 50;
22 22
23 } // namespace 23 } // namespace
24 24
25 ChooserContentView::ChooserContentView( 25 ChooserContentView::ChooserContentView(
26 views::TableViewObserver* table_view_observer, 26 views::TableViewObserver* table_view_observer,
27 std::unique_ptr<ChooserController> chooser_controller) 27 std::unique_ptr<ChooserController> chooser_controller)
28 : chooser_controller_(std::move(chooser_controller)) { 28 : chooser_controller_(std::move(chooser_controller)) {
29 chooser_controller_->set_observer(this); 29 chooser_controller_->set_view(this);
30 std::vector<ui::TableColumn> table_columns; 30 std::vector<ui::TableColumn> table_columns;
31 table_columns.push_back(ui::TableColumn()); 31 table_columns.push_back(ui::TableColumn());
32 table_view_ = 32 table_view_ =
33 new views::TableView(this, table_columns, views::TEXT_ONLY, true); 33 new views::TableView(this, table_columns, views::TEXT_ONLY, true);
34 table_view_->set_select_on_remove(false); 34 table_view_->set_select_on_remove(false);
35 table_view_->SetObserver(table_view_observer); 35 table_view_->SetObserver(table_view_observer);
36 table_view_->SetEnabled(chooser_controller_->NumOptions() > 0); 36 table_view_->SetEnabled(chooser_controller_->NumOptions() > 0);
37 37
38 SetLayoutManager(new views::FillLayout()); 38 SetLayoutManager(new views::FillLayout());
39 views::View* table_parent = table_view_->CreateParentIfNecessary(); 39 views::View* table_parent = table_view_->CreateParentIfNecessary();
40 AddChildView(table_parent); 40 AddChildView(table_parent);
41 41
42 throbber_ = new views::Throbber(); 42 throbber_ = new views::Throbber();
43 // Set the throbber in the center of the chooser. 43 // Set the throbber in the center of the chooser.
44 throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2, 44 throbber_->SetBounds((kChooserWidth - kThrobberDiameter) / 2,
45 (kChooserHeight - kThrobberDiameter) / 2, 45 (kChooserHeight - kThrobberDiameter) / 2,
46 kThrobberDiameter, kThrobberDiameter); 46 kThrobberDiameter, kThrobberDiameter);
47 throbber_->SetVisible(false); 47 throbber_->SetVisible(false);
48 AddChildView(throbber_); 48 AddChildView(throbber_);
49 } 49 }
50 50
51 ChooserContentView::~ChooserContentView() { 51 ChooserContentView::~ChooserContentView() {
52 chooser_controller_->set_observer(nullptr); 52 chooser_controller_->set_view(nullptr);
53 table_view_->SetObserver(nullptr); 53 table_view_->SetObserver(nullptr);
54 table_view_->SetModel(nullptr); 54 table_view_->SetModel(nullptr);
55 if (discovery_state_) 55 if (discovery_state_)
56 discovery_state_->set_listener(nullptr); 56 discovery_state_->set_listener(nullptr);
57 } 57 }
58 58
59 gfx::Size ChooserContentView::GetPreferredSize() const { 59 gfx::Size ChooserContentView::GetPreferredSize() const {
60 return gfx::Size(kChooserWidth, kChooserHeight); 60 return gfx::Size(kChooserWidth, kChooserHeight);
61 } 61 }
62 62
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 } 192 }
193 193
194 void ChooserContentView::UpdateTableView() { 194 void ChooserContentView::UpdateTableView() {
195 if (chooser_controller_->NumOptions() == 0) { 195 if (chooser_controller_->NumOptions() == 0) {
196 table_view_->OnModelChanged(); 196 table_view_->OnModelChanged();
197 table_view_->SetEnabled(false); 197 table_view_->SetEnabled(false);
198 } else { 198 } else {
199 table_view_->SetEnabled(true); 199 table_view_->SetEnabled(true);
200 } 200 }
201 } 201 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chooser_content_view.h ('k') | chrome/browser/usb/usb_chooser_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698