chrome/browser/ui/views/chooser_content_view.cc - Issue 2163683005: Change ChooserController::Observer to ChooserController::View

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chooser_content_view.cc

Issue 2163683005: Change ChooserController::Observer to ChooserController::View (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/chooser_content_view.cc

diff --git a/chrome/browser/ui/views/chooser_content_view.cc b/chrome/browser/ui/views/chooser_content_view.cc

index 2dafa3e20349ff1c89e7b1b88a228c9b8025da5a..81bcbbd3a4c038e86ac178c28c716d5b27c8d742 100644

--- a/chrome/browser/ui/views/chooser_content_view.cc

+++ b/chrome/browser/ui/views/chooser_content_view.cc

@@ -26,7 +26,7 @@ ChooserContentView::ChooserContentView(

views::TableViewObserver* table_view_observer,

std::unique_ptr<ChooserController> chooser_controller)

: chooser_controller_(std::move(chooser_controller)) {

- chooser_controller_->set_observer(this);

+ chooser_controller_->set_view(this);

std::vector<ui::TableColumn> table_columns;

table_columns.push_back(ui::TableColumn());

table_view_ =

@@ -49,7 +49,7 @@ ChooserContentView::ChooserContentView(

}

ChooserContentView::~ChooserContentView() {

- chooser_controller_->set_observer(nullptr);

+ chooser_controller_->set_view(nullptr);

table_view_->SetObserver(nullptr);

table_view_->SetModel(nullptr);

if (discovery_state_)

« no previous file with comments | « chrome/browser/ui/views/chooser_content_view.h ('k') | chrome/browser/usb/usb_chooser_controller.cc » ('j') | no next file with comments »