Change ChooserController::Observer to ChooserController::View

chrome/browser/chooser_controller/chooser_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 #define CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 
 namespace content {
 class RenderFrameHost;
 }
 
 // Subclass ChooserController to implement a chooser, which has some
 // introductory text and a list of options that users can pick one of.
 // Your subclass must define the set of options users can pick from;
 // the actions taken after users select an item or press the 'Cancel'
 // button or the chooser is closed.
 // After Select/Cancel/Close is called, this object is destroyed and
 // calls back into it are not allowed.
 class ChooserController {
  public:
   ChooserController(content::RenderFrameHost* owner,
                     int title_string_id_origin,
                     int title_string_id_extension);
   virtual ~ChooserController();
 
   // Since the set of options can change while the UI is visible an
-  // implementation should register an observer.
-  class Observer {
+  // implementation should register a view.

[msw, 2016/07/20 20:37:07]

nit: "a view to observe changes"

[juncai, 2016/07/20 22:37:45]

Done.

+  class View {
    public:
     // Called after the options list is initialized for the first time.
     // OnOptionsInitialized should only be called once.
     virtual void OnOptionsInitialized() = 0;
 
     // Called after GetOption(index) has been added to the options and the
     // newly added option is the last element in the options list. Calling
     // GetOption(index) from inside a call to OnOptionAdded will see the
     // added string since the options have already been updated.
     virtual void OnOptionAdded(size_t index) = 0;
 
     // Called when GetOption(index) is no longer present, and all later
     // options have been moved earlier by 1 slot. Calling GetOption(index)
     // from inside a call to OnOptionRemoved will NOT see the removed string
     // since the options have already been updated.
     virtual void OnOptionRemoved(size_t index) = 0;
 
     // Called when the device adapter is turned on or off.
     virtual void OnAdapterEnabledChanged(bool enabled) = 0;
 
     // Called when refreshing options is in progress or complete.
     virtual void OnRefreshStateChanged(bool refreshing) = 0;
 
    protected:
-    virtual ~Observer() {}
+    virtual ~View() {}
   };
 
   // Returns the text to be displayed in the chooser title.
   base::string16 GetTitle() const;
 
   // Returns the text to be displayed in the chooser when there are no options.
   virtual base::string16 GetNoOptionsText() const = 0;
 
   // Returns the label for OK button.
   virtual base::string16 GetOkButtonLabel() const = 0;
@@ skipping 20 matching lines @@
   // Called when the user presses the 'Cancel' button in the dialog.
   virtual void Cancel() = 0;
 
   // Called when the user clicks outside the dialog or the dialog otherwise
   // closes without the user taking an explicit action.
   virtual void Close() = 0;
 
   // Open help center URL.
   virtual void OpenHelpCenterUrl() const = 0;
 
-  // Only one observer may be registered at a time.
-  void set_observer(Observer* observer) { observer_ = observer; }
-  Observer* observer() const { return observer_; }
+  // Only one view may be registered at a time.
+  void set_view(View* view) { view_ = view; }
+  View* view() const { return view_; }
 
  private:
   content::RenderFrameHost* const owning_frame_;
   const int title_string_id_origin_;
   const int title_string_id_extension_;
-  Observer* observer_ = nullptr;
+  View* view_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserController);
 };
 
 #endif  // CHROME_BROWSER_CHOOSER_CONTROLLER_CHOOSER_CONTROLLER_H_