chrome/browser/chooser_controller/mock_chooser_controller.cc - Issue 2163683005: Change ChooserController::Observer to ChooserController::View

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chooser_controller/mock_chooser_controller.cc

Issue 2163683005: Change ChooserController::Observer to ChooserController::View (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chooser_controller/chooser_controller.h ('k') | chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chooser_controller/mock_chooser_controller.cc

diff --git a/chrome/browser/chooser_controller/mock_chooser_controller.cc b/chrome/browser/chooser_controller/mock_chooser_controller.cc

index 0b5be9e9f87769d066101321c8793cb78915efe1..5eb14eae246b56ebc5e97907d11cfa25b6824fb2 100644

--- a/chrome/browser/chooser_controller/mock_chooser_controller.cc

+++ b/chrome/browser/chooser_controller/mock_chooser_controller.cc

@@ -38,8 +38,8 @@ base::string16 MockChooserController::GetStatus() const {

void MockChooserController::OptionAdded(const base::string16 option_name) {

option_names_.push_back(option_name);

- if (observer())

- observer()->OnOptionAdded(option_names_.size() - 1);

+ if (view())

+ view()->OnOptionAdded(option_names_.size() - 1);

}

void MockChooserController::OptionRemoved(const base::string16 option_name) {

@@ -47,8 +47,8 @@ void MockChooserController::OptionRemoved(const base::string16 option_name) {

if (*it == option_name) {

size_t index = it - option_names_.begin();

option_names_.erase(it);

- if (observer())

- observer()->OnOptionRemoved(index);

+ if (view())

+ view()->OnOptionRemoved(index);

return;

}