Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932
Committed: https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227
Cr-Commit-Position: refs/heads/master@{#408988}

[caseq, 2016-07-19 00:18:10]

Description was changed from

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

BUG=599932
==========

to

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932
==========

[caseq, 2016-07-19 00:18:10]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, oysteine@chromium.org

[dgozman, 2016-07-19 01:53:14]

lgtm

https://codereview.chromium.org/2161583004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/2161583004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/tracing_handler.cc:107: std::unique_ptr<const
base::DictionaryValue> metadata) override {
Don't you want to send metadata as well?

https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html
(right):

https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html:65:
var trace = JSON.parse(data1)
nit: missing semicolon

https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html:67:
assertEqual("object", typeof trace["metadata"]);
Let's dump the typeof instead?

[caseq, 2016-07-19 18:57:20]

Oystein, could you please stamp the content/browser/tracing part?


On 2016/07/19 01:53:14, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2161583004/diff/1/content/browser/devtools/pr...
> File content/browser/devtools/protocol/tracing_handler.cc (right):
> 
>
https://codereview.chromium.org/2161583004/diff/1/content/browser/devtools/pr...
> content/browser/devtools/protocol/tracing_handler.cc:107:
std::unique_ptr<const
> base::DictionaryValue> metadata) override {
> Don't you want to send metadata as well?

These are already within the stream. Unfortunately, we can't drop them from the
interface (yet), as these are used by some other consumers.

>
https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html
> (right):
> 
>
https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html:65:
> var trace = JSON.parse(data1)
> nit: missing semicolon

Fixed.

>
https://codereview.chromium.org/2161583004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html:67:
> assertEqual("object", typeof trace["metadata"]);
> Let's dump the typeof instead?

Fixed.

[oystein (OOO til 10th of July), 2016-07-19 18:58:37]

content/browser/tracing lgtm!

[caseq, 2016-07-19 18:59:15]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-07-19 18:59:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2161583004/#ps20001
(title: "review comments addressed")

[caseq, 2016-07-19 18:59:25]

The CQ bit was unchecked by caseq@chromium.org

[caseq, 2016-07-29 22:52:47]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-07-29 22:53:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 23:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 23:48:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[caseq, 2016-07-30 00:35:27]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 00:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 03:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 03:17:53]

Dry run: This issue passed the CQ dry run.

[caseq, 2016-08-01 16:10:05]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-08-01 16:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 17:17:24]

Description was changed from

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932
==========

to

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932
==========

[commit-bot: I haz the power, 2016-08-01 17:17:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-01 17:18:42]

Description was changed from

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932
==========

to

==========
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

... so that we return traces from all agents and metadata to clients.

This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.

BUG=599932

Committed: https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227
Cr-Commit-Position: refs/heads/master@{#408988}
==========

[commit-bot: I haz the power, 2016-08-01 17:18:44]

Patchset 2 (id:??) landed as
https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227
Cr-Commit-Position: refs/heads/master@{#408988}