Chromium Code Reviews Chromium Code Reviews
Issue 2161583004:
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <style> | 3 <style> |
| 4 div#test { | 4 div#test { |
| 5 display: none; | 5 display: none; |
| 6 background-color: blue; | 6 background-color: blue; |
| 7 width: 100px; | 7 width: 100px; |
| 8 height: 100px; | 8 height: 100px; |
| 9 } | 9 } |
| 10 </style> | 10 </style> |
| (...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 55 InspectorTest.sendCommand("IO.read", { handle: streamHandle }, onRea dAfterClose); | 55 InspectorTest.sendCommand("IO.read", { handle: streamHandle }, onRea dAfterClose); |
| 56 } | 56 } |
| 57 function onReadAfterClose(response) | 57 function onReadAfterClose(response) |
| 58 { | 58 { |
| 59 InspectorTest.log("Error after illegal read: " + JSON.stringify(resp onse.error)); | 59 InspectorTest.log("Error after illegal read: " + JSON.stringify(resp onse.error)); |
| 60 InspectorTest.sendCommand("IO.close", { handle: streamHandle }, onCl oseAfterClose); | 60 InspectorTest.sendCommand("IO.close", { handle: streamHandle }, onCl oseAfterClose); |
| 61 } | 61 } |
| 62 function onCloseAfterClose(response) | 62 function onCloseAfterClose(response) |
| 63 { | 63 { |
| 64 InspectorTest.log("Error after illegal close: " + JSON.stringify(res ponse.error)); | 64 InspectorTest.log("Error after illegal close: " + JSON.stringify(res ponse.error)); |
| 65 performEventsSanityCheck(JSON.parse(data1)); | 65 var trace = JSON.parse(data1) |
|
dgozman
2016/07/19 01:53:14
nit: missing semicolon
| |
| 66 performEventsSanityCheck(trace["traceEvents"]); | |
| 67 assertEqual("object", typeof trace["metadata"]); | |
|
dgozman
2016/07/19 01:53:14
Let's dump the typeof instead?
| |
| 66 } | 68 } |
| 67 } | 69 } |
| 68 | 70 |
| 69 function assertGreaterOrEqual(a, b, message) | 71 function assertGreaterOrEqual(a, b, message) |
| 70 { | 72 { |
| 71 if (a >= b) | 73 if (a >= b) |
| 72 return; | 74 return; |
| 73 InspectorTest.log(message + " (" + a + " < " + b + ")"); | 75 InspectorTest.log(message + " (" + a + " < " + b + ")"); |
| 74 InspectorTest.completeTest(); | 76 InspectorTest.completeTest(); |
| 75 } | 77 } |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 99 InspectorTest.completeTest(); | 101 InspectorTest.completeTest(); |
| 100 } | 102 } |
| 101 } | 103 } |
| 102 </script> | 104 </script> |
| 103 </head> | 105 </head> |
| 104 <body onload="runTest()"> | 106 <body onload="runTest()"> |
| 105 <div id="test"> | 107 <div id="test"> |
| 106 </div> | 108 </div> |
| 107 </body> | 109 </body> |
| 108 </html> | 110 </html> |
| OLD | NEW |
