content/browser/tracing/tracing_controller_impl.h - Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.h

Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.cc ('k') | content/browser/tracing/tracing_controller_impl_data_sinks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/tracing_controller_impl.h

diff --git a/content/browser/tracing/tracing_controller_impl.h b/content/browser/tracing/tracing_controller_impl.h

index 818f1d5f1fcf681e294c4edca249056f448ee295..44b4c8f610018bef6af27960e64769ecf49b4a7b 100644

--- a/content/browser/tracing/tracing_controller_impl.h

+++ b/content/browser/tracing/tracing_controller_impl.h

@@ -59,6 +59,8 @@ class TracingControllerImpl

CONTENT_EXPORT static scoped_refptr<TraceDataSink> CreateCompressedStringSink(

scoped_refptr<TraceDataEndpoint> endpoint);

+ static scoped_refptr<TraceDataSink> CreateJSONSink(

+ scoped_refptr<TraceDataEndpoint> endpoint);

static TracingControllerImpl* GetInstance();