Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: content/browser/devtools/devtools_io_context.cc

Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_io_context.cc
diff --git a/content/browser/devtools/devtools_io_context.cc b/content/browser/devtools/devtools_io_context.cc
index 4b2778b24c8e797c55e8c483a88df21c5ff2a173..55f65f8c373459862b21d124be94fcbac0a224ea 100644
--- a/content/browser/devtools/devtools_io_context.cc
+++ b/content/browser/devtools/devtools_io_context.cc
@@ -62,9 +62,10 @@ void Stream::Read(off_t position, size_t max_size, ReadCallback callback) {
callback));
}
-void Stream::Append(const scoped_refptr<base::RefCountedString>& data) {
+void Stream::Append(std::unique_ptr<std::string> data) {
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
- base::Bind(&Stream::AppendOnFileThread, this, data));
+ base::Bind(&Stream::AppendOnFileThread, this,
+ base::Passed(std::move(data))));
}
void Stream::ReadOnFileThread(off_t position, size_t max_size,
@@ -101,14 +102,12 @@ void Stream::ReadOnFileThread(off_t position, size_t max_size,
base::Bind(callback, data, status));
}
-void Stream::AppendOnFileThread(
- const scoped_refptr<base::RefCountedString>& data) {
+void Stream::AppendOnFileThread(std::unique_ptr<std::string> data) {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
if (!InitOnFileThreadIfNeeded())
return;
- const std::string& buffer = data->data();
- int size_written = file_.WriteAtCurrentPos(&*buffer.begin(), buffer.size());
- if (size_written != static_cast<int>(buffer.size())) {
+ int size_written = file_.WriteAtCurrentPos(data->data(), data->size());
+ if (size_written != static_cast<int>(data->size())) {
LOG(ERROR) << "Failed to write temporary file";
had_errors_ = true;
file_.Close();
« no previous file with comments | « content/browser/devtools/devtools_io_context.h ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698