Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: content/browser/devtools/devtools_io_context.h

Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_io_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_io_context.h
diff --git a/content/browser/devtools/devtools_io_context.h b/content/browser/devtools/devtools_io_context.h
index 54b4a72938b0748a491ec99c5fef52c26119aab9..ece5d66a867c199f11b6172c2cecb0edd887667c 100644
--- a/content/browser/devtools/devtools_io_context.h
+++ b/content/browser/devtools/devtools_io_context.h
@@ -28,7 +28,7 @@ class DevToolsIOContext {
void(const scoped_refptr<base::RefCountedString>& data, int status)>;
void Read(off_t position, size_t max_size, ReadCallback callback);
- void Append(const scoped_refptr<base::RefCountedString>& data);
+ void Append(std::unique_ptr<std::string> data);
const std::string& handle() const { return handle_; }
private:
@@ -39,7 +39,7 @@ class DevToolsIOContext {
friend class base::DeleteHelper<Stream>;
void ReadOnFileThread(off_t pos, size_t max_size, ReadCallback callback);
- void AppendOnFileThread(const scoped_refptr<base::RefCountedString>& data);
+ void AppendOnFileThread(std::unique_ptr<std::string> data);
bool InitOnFileThreadIfNeeded();
const std::string handle_;
« no previous file with comments | « no previous file | content/browser/devtools/devtools_io_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698