content/browser/tracing/tracing_controller_impl_data_sinks.cc - Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl_data_sinks.cc

Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/tracing/tracing_controller_impl.h ('k') | third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/tracing_controller_impl_data_sinks.cc

diff --git a/content/browser/tracing/tracing_controller_impl_data_sinks.cc b/content/browser/tracing/tracing_controller_impl_data_sinks.cc

index 86f0df224ba888da6fb8b8e8458301ddfc6316ae..8c4e19816615f0692c5f72a751e7689bbd937e69 100644

--- a/content/browser/tracing/tracing_controller_impl_data_sinks.cc

+++ b/content/browser/tracing/tracing_controller_impl_data_sinks.cc

@@ -336,4 +336,10 @@ scoped_refptr<TraceDataEndpoint> TracingControllerImpl::CreateCallbackEndpoint(

return new StringTraceDataEndpoint(callback);

}

+scoped_refptr<TracingController::TraceDataSink>

+TracingControllerImpl::CreateJSONSink(

+ scoped_refptr<TraceDataEndpoint> endpoint) {

+ return new JSONTraceDataSink(endpoint);

} // namespace content