DevTools: Use proper target when processing worker thread events.

DevTools: Use proper target when processing worker thread events.

BUG=627661
Committed: https://crrev.com/3b9268f7ecb6122a9ca5af3a243947f4fa86eda2
Cr-Commit-Position: refs/heads/master@{#406453}

[alph, 2016-07-19 20:41:17]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, kozyatinskiy@chromium.org, lushnikov@chromium.org

[alph, 2016-07-19 20:41:17]

caseq could you please take a look.

[caseq, 2016-07-19 22:48:58]

lgtm

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1091: var
target = this._model.targetByEvent(event);
I think it should be fine to use main target here, since we won't really depend
on the inspected page state here in case of loaded timeline.

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:355:
var link = this._treeView._linkifyLocation(event)
terminate with ";"

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:482:
return !workerId ? mainTarget :
mainTarget.workerManager.targetByWorkerId(workerId);
please get rid of negation and swap branches. better yet, replace with if and
move the vars above under corresponding branches of if.

[alph, 2016-07-19 23:10:29]

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1091: var
target = this._model.targetByEvent(event);
On 2016/07/19 22:48:58, caseq wrote:
> I think it should be fine to use main target here, since we won't really
depend
> on the inspected page state here in case of loaded timeline.

Done.

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:355:
var link = this._treeView._linkifyLocation(event)
On 2016/07/19 22:48:58, caseq wrote:
> terminate with ";"

Done.

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2161253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:482:
return !workerId ? mainTarget :
mainTarget.workerManager.targetByWorkerId(workerId);
On 2016/07/19 22:48:58, caseq wrote:
> please get rid of negation and swap branches. better yet, replace with if and
> move the vars above under corresponding branches of if.

reversed the negation. Didn't get the second part though.

[alph, 2016-07-19 23:10:33]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-19 23:10:33]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2161253002/#ps20001
(title: "addressing comments.")

[commit-bot: I haz the power, 2016-07-19 23:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 01:55:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 01:55:15]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 01:57:44]

Description was changed from

==========
DevTools: Use proper target when processing worker thread events.

BUG=627661
==========

to

==========
DevTools: Use proper target when processing worker thread events.

BUG=627661

Committed: https://crrev.com/3b9268f7ecb6122a9ca5af3a243947f4fa86eda2
Cr-Commit-Position: refs/heads/master@{#406453}
==========

[commit-bot: I haz the power, 2016-07-20 01:57:46]

Patchset 2 (id:??) landed as
https://crrev.com/3b9268f7ecb6122a9ca5af3a243947f4fa86eda2
Cr-Commit-Position: refs/heads/master@{#406453}