third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 2161253002: DevTools: Use proper target when processing worker thread events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index f7154e4d5b11623345cafcc006cbabc6a3095275..44aedd577cac61716f53ed03a10a5e0cfb05a801 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -357,7 +357,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

return WebInspector.UIString("Blackboxed");

var name = WebInspector.TimelineUIUtils.eventStyle(event).title;

// TODO(yurys): support event dividers

- var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, this._model.target());

+ var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, this._model.targetByEvent(event));

if (event.name === WebInspector.TimelineModel.RecordType.JSFrame && detailsText)

return detailsText;

return detailsText ? WebInspector.UIString("%s (%s)", name, detailsText) : name;