Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
index 5ff5f37bae8967f6acd1bdec7dc24b88304bb36b..d5cb9be0139df292056f194ab1e472aa1b4b690a 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
@@ -203,17 +203,17 @@ WebInspector.TimelineProfileTree.eventURL = function(event)
/**
* @param {!WebInspector.TracingModel.Event} event
- * @return {?Object}
+ * @return {?RuntimeAgent.CallFrame}
*/
WebInspector.TimelineProfileTree.eventStackFrame = function(event)
{
if (event.name === WebInspector.TimelineModel.RecordType.JSFrame)
- return event.args["data"];
+ return /** @type {?RuntimeAgent.CallFrame} */ (event.args["data"] || null);
var topFrame = event.stackTrace && event.stackTrace[0];
if (topFrame)
- return topFrame;
+ return /** @type {!RuntimeAgent.CallFrame} */ (topFrame);
var initiator = event.initiator;
- return initiator && initiator.stackTrace && initiator.stackTrace[0] || null;
+ return /** @type {?RuntimeAgent.CallFrame} */ (initiator && initiator.stackTrace && initiator.stackTrace[0] || null);
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698