third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 2161253002: DevTools: Use proper target when processing worker thread events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index d567d30be2f1cdd11ed018ecab218be3c76bfecc..7bbc5571343ff562a5d4673920510ec4b5499b14 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -774,7 +774,7 @@ WebInspector.TimelinePanel.prototype = {

this._statusPane.updateStatus(WebInspector.UIString("Processing timeline\u2026"));

this._model.setEvents(this._tracingModel, loadedFromFile);

this._frameModel.reset();

- this._frameModel.addTraceEvents(this._model.target(), this._model.inspectedTargetEvents(), this._model.sessionId() || "");

+ this._frameModel.addTraceEvents(WebInspector.targetManager.mainTarget(), this._model.inspectedTargetEvents(), this._model.sessionId() || "");

var groups = WebInspector.TimelineModel.AsyncEventGroup;

var asyncEventsByGroup = this._model.mainThreadAsyncEvents();

@@ -1088,7 +1088,7 @@ WebInspector.TimelinePanel.prototype = {

_showEventInPaintProfiler: function(event, isCloseable)

{

- var target = this._model.target();

+ var target = WebInspector.targetManager.mainTarget();

if (!target)

return;

var paintProfilerView = this._paintProfilerView();