third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html - Issue 2161253002: DevTools: Use proper target when processing worker thread events.

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

index d58625251c326bebd848be44b42d5e3c9e6fb0ff..5b98db768890b10d11ff5dd085eed162f480eb83 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

@@ -30,8 +30,9 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("TimerFire");

InspectorTest.check(record, "Should receive a TimerFire record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), null, contentHelper);

+ var event = record.traceEvent();

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().targetByEvent(event), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);

var causes = contentHelper.element.deepTextContent();

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Timer InstalledsetTimeoutFunction @ setTimeoutFunction.js:");

@@ -56,8 +57,9 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("FireAnimationFrame");

InspectorTest.check(record, "Should receive a FireAnimationFrame record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), null, contentHelper);

+ var event = record.traceEvent();

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().targetByEvent(event), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);

var causes = contentHelper.element.deepTextContent();

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Animation Frame RequestedrequestAnimationFrameFunction @ requestAnimationFrameFunction.js:");

@@ -84,8 +86,9 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("UpdateLayoutTree");

InspectorTest.check(record, "Should receive a UpdateLayoutTree record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), null, contentHelper);

+ var event = record.traceEvent();

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().targetByEvent(event), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);

var causes = contentHelper.element.deepTextContent();

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "First InvalidatedstyleRecalcFunction @ styleRecalcFunction.js:");

@@ -112,8 +115,9 @@ function test()

var linkifier = new WebInspector.Linkifier();

var record = InspectorTest.findFirstTimelineRecord("Layout");

InspectorTest.check(record, "Should receive a Layout record.");

- var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().target(), linkifier, true);

- WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), InspectorTest.timelineModel().target(), null, contentHelper);

+ var event = record.traceEvent();

+ var contentHelper = new WebInspector.TimelineDetailsContentHelper(InspectorTest.timelineModel().targetByEvent(event), linkifier, true);

+ WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);

var causes = contentHelper.element.deepTextContent();

InspectorTest.check(causes, "Should generate causes");

checkStringContains(causes, "Layout ForcedlayoutFunction @ layoutFunction.js:");