third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html - Issue 2161253002: DevTools: Use proper target when processing worker thread events.

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html ('k') | third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../http/tests/inspector/inspector-test.js"></script>	4 <script src="../../../http/tests/inspector/inspector-test.js"></script>

5 <script src="../../../http/tests/inspector/timeline-test.js"></script>	5 <script src="../../../http/tests/inspector/timeline-test.js"></script>

6 <script>	6 <script>

7 function display(callback)	7 function display(callback)

8 {	8 {

9 requestAnimationFrame(function() {	9 requestAnimationFrame(function() {

10 var testElements = document.body.getElementsByClassName("testElement");	10 var testElements = document.body.getElementsByClassName("testElement");

(...skipping 10 matching lines...) Expand all Loading...
21 {	21 {

22 var currentPanel = WebInspector.inspectorView.currentPanel();	22 var currentPanel = WebInspector.inspectorView.currentPanel();

23 InspectorTest.assertEquals(currentPanel._panelName, "timeline", "Current pan el should be the timeline.");	23 InspectorTest.assertEquals(currentPanel._panelName, "timeline", "Current pan el should be the timeline.");

24 Runtime.experiments.enableForTest("timelineInvalidationTracking");	24 Runtime.experiments.enableForTest("timelineInvalidationTracking");

25	25

26 InspectorTest.invokeAsyncWithTimeline("display", function() {	26 InspectorTest.invokeAsyncWithTimeline("display", function() {

27 var record = InspectorTest.findFirstTimelineRecord(WebInspector.Timeline Model.RecordType.Paint);	27 var record = InspectorTest.findFirstTimelineRecord(WebInspector.Timeline Model.RecordType.Paint);

28 InspectorTest.addArray(record._event.invalidationTrackingEvents, Inspect orTest.InvalidationFormatters, "", "paint invalidations");	28 InspectorTest.addArray(record._event.invalidationTrackingEvents, Inspect orTest.InvalidationFormatters, "", "paint invalidations");

29	29

30 var linkifier = new WebInspector.Linkifier();	30 var linkifier = new WebInspector.Linkifier();

31 var target = InspectorTest.timelineModel().target();	31 var event = record.traceEvent();

	32 var target = InspectorTest.timelineModel().targetByEvent(event);

32 var contentHelper = new WebInspector.TimelineDetailsContentHelper(target , linkifier, true);	33 var contentHelper = new WebInspector.TimelineDetailsContentHelper(target , linkifier, true);

33 WebInspector.TimelineUIUtils._generateCauses(record.traceEvent(), target , null, contentHelper);	34 WebInspector.TimelineUIUtils._generateCauses(event, target, null, conten tHelper);

34 var invalidationsTree = contentHelper.element.getElementsByClassName("in validations-tree")[0];	35 var invalidationsTree = contentHelper.element.getElementsByClassName("in validations-tree")[0];

35 var invalidations = invalidationsTree.shadowRoot.textContent;	36 var invalidations = invalidationsTree.shadowRoot.textContent;

36 checkStringContains(invalidations, "Inline CSS style declaration was mut ated for [ DIV class='testElement' ], [ DIV class='testElement' ], and 2 others. (anonymous function) @ timeline-grouped-invalidations.html:12");	37 checkStringContains(invalidations, "Inline CSS style declaration was mut ated for [ DIV class='testElement' ], [ DIV class='testElement' ], and 2 others. (anonymous function) @ timeline-grouped-invalidations.html:12");

37 checkStringContains(invalidations, "Inline CSS style declaration was mut ated for [ DIV class='testElement' ], [ DIV class='testElement' ], and 2 others. (anonymous function) @ timeline-grouped-invalidations.html:13");	38 checkStringContains(invalidations, "Inline CSS style declaration was mut ated for [ DIV class='testElement' ], [ DIV class='testElement' ], and 2 others. (anonymous function) @ timeline-grouped-invalidations.html:13");

38 InspectorTest.completeTest();	39 InspectorTest.completeTest();

39 });	40 });

40	41

41 function checkStringContains(string, contains)	42 function checkStringContains(string, contains)

42 {	43 {

43 var doesContain = string.indexOf(contains) >= 0;	44 var doesContain = string.indexOf(contains) >= 0;

44 InspectorTest.check(doesContain, contains + " should be present in " + s tring);	45 InspectorTest.check(doesContain, contains + " should be present in " + s tring);

45 InspectorTest.addResult("PASS - record contained " + contains);	46 InspectorTest.addResult("PASS - record contained " + contains);

46 }	47 }

47 }	48 }

48 </script>	49 </script>

49 </head>	50 </head>

50 <body onload="runTest()">	51 <body onload="runTest()">

51 <p>Tests grouped invalidations on the timeline.</p>	52 <p>Tests grouped invalidations on the timeline.</p>

52 <div class="testElement">P</div><div class="testElement">A</div>	53 <div class="testElement">P</div><div class="testElement">A</div>

53 <div class="testElement">S</div><div class="testElement">S</div>	54 <div class="testElement">S</div><div class="testElement">S</div>

54 </body>	55 </body>

55 </html>	56 </html>

OLD	NEW