Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove V8Debugger::consoleMessagesCount. Migrated tests which used that to protocol. BUG=none Committed: https://crrev.com/b2ddee04ff5d2a48162a4c3146d3e9a6455e0b7f Cr-Commit-Position: refs/heads/master@{#405793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -92 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/promise-rejection-events-console.html View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html View 2 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation-expected.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html View 3 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt View 1 chunk +5 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-promise-reject-and-handle.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-promise-reject-and-handle-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-enabled/resources/console-clear-arguments-test.js View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2151273003 Patch 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 5 months ago (2016-07-15 16:44:19 UTC) #2
kozy
lgtm
4 years, 5 months ago (2016-07-15 16:49:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150993004/1
4 years, 5 months ago (2016-07-15 16:50:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:13:38 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:16:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b2ddee04ff5d2a48162a4c3146d3e9a6455e0b7f
Cr-Commit-Position: refs/heads/master@{#405793}

Powered by Google App Engine
This is Rietveld 408576698