Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
index 97b58d09f43b6c9f910dfd65cb7601fe4337a744..1e368354bfcc4556c3ffe39930d0ed6baabf71ef 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
@@ -1102,20 +1102,6 @@ void V8DebuggerImpl::promiseRejectionRevoked(v8::Local<v8::Context> context, uns
ensureConsoleMessageStorage(contextGroupId)->addMessage(std::move(consoleMessage));
}
-void V8DebuggerImpl::consoleMessagesCount(int contextGroupId, unsigned* total, unsigned* withArguments)
-{
- *total = 0;
- *withArguments = 0;
- ConsoleStorageMap::iterator storageIt = m_consoleStorageMap.find(contextGroupId);
- if (storageIt == m_consoleStorageMap.end())
- return;
- *total = storageIt->second->messages().size();
- for (const auto& message : storageIt->second->messages()) {
- if (message->argumentCount())
- (*withArguments)++;
- }
-}
-
std::unique_ptr<V8StackTrace> V8DebuggerImpl::captureStackTrace(bool fullStack)
{
if (!m_isolate->InContext())

Powered by Google App Engine
This is Rietveld 408576698