Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8Debugger_h 5 #ifndef V8Debugger_h
6 #define V8Debugger_h 6 #define V8Debugger_h
7 7
8 #include "platform/inspector_protocol/Platform.h" 8 #include "platform/inspector_protocol/Platform.h"
9 #include "platform/inspector_protocol/String16.h" 9 #include "platform/inspector_protocol/String16.h"
10 #include "platform/v8_inspector/public/V8ConsoleTypes.h" 10 #include "platform/v8_inspector/public/V8ConsoleTypes.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // Runtime instrumentation. 49 // Runtime instrumentation.
50 // TODO(dgozman): can we pass exception object? 50 // TODO(dgozman): can we pass exception object?
51 virtual void exceptionThrown(int contextGroupId, const String16& errorMessag e, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ ptr<V8StackTrace>, int scriptId) = 0; 51 virtual void exceptionThrown(int contextGroupId, const String16& errorMessag e, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ ptr<V8StackTrace>, int scriptId) = 0;
52 virtual unsigned promiseRejected(v8::Local<v8::Context>, const String16& err orMessage, v8::Local<v8::Value> exception, const String16& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) = 0; 52 virtual unsigned promiseRejected(v8::Local<v8::Context>, const String16& err orMessage, v8::Local<v8::Value> exception, const String16& url, unsigned lineNum ber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) = 0;
53 virtual void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promis eRejectionId) = 0; 53 virtual void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promis eRejectionId) = 0;
54 54
55 // TODO(dgozman): remove requestIdentifier. 55 // TODO(dgozman): remove requestIdentifier.
56 virtual void addConsoleMessage(int contextGroupId, MessageSource, MessageLev el, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId, const String16& reque stIdentifier, const String16& workerId) = 0; 56 virtual void addConsoleMessage(int contextGroupId, MessageSource, MessageLev el, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId, const String16& reque stIdentifier, const String16& workerId) = 0;
57 // TODO(dgozman): can we remove this method? 57 // TODO(dgozman): can we remove this method?
58 virtual void logToConsole(v8::Local<v8::Context>, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) = 0; 58 virtual void logToConsole(v8::Local<v8::Context>, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) = 0;
59 // TODO(dgozman): try to remove this.
60 virtual void consoleMessagesCount(int contextGroupId, unsigned* total, unsig ned* withArguments) = 0;
61 59
62 // API methods. 60 // API methods.
63 virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, prot ocol::FrontendChannel*, V8InspectorSessionClient*, const String16* state) = 0; 61 virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, prot ocol::FrontendChannel*, V8InspectorSessionClient*, const String16* state) = 0;
64 virtual std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTr ace>) = 0; 62 virtual std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTr ace>) = 0;
65 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0; 63 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0;
66 }; 64 };
67 65
68 } // namespace blink 66 } // namespace blink
69 67
70 68
71 #endif // V8Debugger_h 69 #endif // V8Debugger_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698