third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html - Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

index 314de51323ab1067c155114913fc79730a9fb730..b17cf21e0750a3931965af830df64ce84c9659eb 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

@@ -1,6 +1,7 @@

<html>

<head>

-<script src="resources/console-clear-arguments-test.js"></script>

+<script src="../inspector/inspector-test.js"></script>

+<script src="../inspector/console-test.js"></script>

if (window.testRunner) {

testRunner.waitUntilDone();

@@ -15,9 +16,9 @@ function removeIFrame()

container.removeChild(child);

child = container.firstChild;

}

- dumpConsoleMessageCounts();

if (window.testRunner)

- testRunner.notifyDone();

+ testRunner.showWebInspector();

+ runTest();

}

function createIFrame()

@@ -28,11 +29,19 @@ function createIFrame()

document.getElementById('container').appendChild(iframe);

}

+function test()

+ for (var message of InspectorTest.mainTarget.consoleModel.messages()) {

+ var args = (message.parameters || []).map((arg) => arg.type);

+ InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]");

+ }

+ InspectorTest.completeTest();

</script>

</head>

<p>

-Tests that console message arguments will be cleared when iframe where the messages were

+Tests that console message arguments will be cleared and first argument will be converted into a string when iframe where the messages were

created is removed.

</p>