[DevTools] Move browser logging from Console domain to Log domain.

[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log domain.

BUG=613882
Committed: https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2
Cr-Commit-Position: refs/heads/master@{#406211}

[dgozman, 2016-07-16 01:40:04]

Description was changed from

==========
[DevTools] Move browser logging from Console domain to Log domain.

BUG=613882
==========

to

==========
[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log
domain.

BUG=613882
==========

[dgozman, 2016-07-16 01:40:18]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-07-16 01:40:19]

Take a look please.

[dgozman, 2016-07-16 01:40:26]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 01:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-07-16 01:56:10]

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4192: "id":
"Location",
inline?

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4197: { "name":
"scriptId", "$ref": "Runtime.ScriptId", "optional": true, "description": "Id of
script resource when available." },
Do we need this?

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4199: { "name":
"columnNumber", "type": "integer", "optional": true, "description": "Column
number in the resource." },
I don't think we pass it outside stack.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:257: "name":
"clearMessages",
discardConsoleEntries

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:258:
"description": "Clears collected exceptions and console API calls."
hidden

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:741: { "name":
"scriptId", "type": "string", "optional": true, "description": "Never present."
},
nuke, it was optional, so you are free to not pass it.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:747: { "name":
"stack", "$ref": "Runtime.StackTrace", "optional": true, "description": "Never
present." },
nuke, it was optional, so you are free to not pass it.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:748: { "name":
"networkRequestId", "type": "string", "optional": true, "description": "Never
present. Use Log domain instead." }
nuke, it was optional, so you are free to not pass it.

[commit-bot: I haz the power, 2016-07-16 03:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 03:42:08]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-18 19:18:53]

PTAL

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4192: "id":
"Location",
On 2016/07/16 01:56:09, pfeldman wrote:
> inline?

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4197: { "name":
"scriptId", "$ref": "Runtime.ScriptId", "optional": true, "description": "Id of
script resource when available." },
On 2016/07/16 01:56:09, pfeldman wrote:
> Do we need this?

Removed.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:4199: { "name":
"columnNumber", "type": "integer", "optional": true, "description": "Column
number in the resource." },
On 2016/07/16 01:56:09, pfeldman wrote:
> I don't think we pass it outside stack.

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:257: "name":
"clearMessages",
On 2016/07/16 01:56:10, pfeldman wrote:
> discardConsoleEntries

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:258:
"description": "Clears collected exceptions and console API calls."
On 2016/07/16 01:56:10, pfeldman wrote:
> hidden

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:741: { "name":
"scriptId", "type": "string", "optional": true, "description": "Never present."
},
On 2016/07/16 01:56:09, pfeldman wrote:
> nuke, it was optional, so you are free to not pass it.

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:747: { "name":
"stack", "$ref": "Runtime.StackTrace", "optional": true, "description": "Never
present." },
On 2016/07/16 01:56:10, pfeldman wrote:
> nuke, it was optional, so you are free to not pass it.

Done.

https://codereview.chromium.org/2151273003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:748: { "name":
"networkRequestId", "type": "string", "optional": true, "description": "Never
present. Use Log domain instead." }
On 2016/07/16 01:56:10, pfeldman wrote:
> nuke, it was optional, so you are free to not pass it.

Done.

[kozy, 2016-07-18 19:32:54]

lgtm

https://codereview.chromium.org/2151273003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
(right):

https://codereview.chromium.org/2151273003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html:60:
setImmediate(function() { WebInspector.ConsoleView.clearConsole(); });
() => WebInspector.ConsoleView.clearConsole()

[pfeldman, 2016-07-18 23:48:35]

owner lgtm if you need it.

[dgozman, 2016-07-18 23:53:31]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:54:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 04:15:51]

Description was changed from

==========
[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log
domain.

BUG=613882
==========

to

==========
[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log
domain.

BUG=613882
==========

[commit-bot: I haz the power, 2016-07-19 04:15:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 04:15:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 04:17:13]

Description was changed from

==========
[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log
domain.

BUG=613882
==========

to

==========
[DevTools] Move browser logging from Console domain to Log domain.

Deprecated Console domain.
All the messages except for console API and exceptions are reported through Log
domain.

BUG=613882

Committed: https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2
Cr-Commit-Position: refs/heads/master@{#406211}
==========

[commit-bot: I haz the power, 2016-07-19 04:17:14]

Patchset 5 (id:??) landed as
https://crrev.com/7151bfa310cc76415c6743ccb3aa80e5392205d2
Cr-Commit-Position: refs/heads/master@{#406211}