Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2150993004: [DevTools] Remove V8Debugger::consoleMessagesCount. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleMessage.h" 5 #include "platform/v8_inspector/V8ConsoleMessage.h"
6 6
7 #include "platform/v8_inspector/InspectedContext.h" 7 #include "platform/v8_inspector/InspectedContext.h"
8 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 8 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
9 #include "platform/v8_inspector/V8DebuggerImpl.h" 9 #include "platform/v8_inspector/V8DebuggerImpl.h"
10 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 10 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 v8::HandleScope handles(isolate); 349 v8::HandleScope handles(isolate);
350 // TODO(dgozman): should we use different object group? 350 // TODO(dgozman): should we use different object group?
351 return session->wrapObject(inspectedContext->context(), m_arguments[0]->Get( isolate), "console", generatePreview); 351 return session->wrapObject(inspectedContext->context(), m_arguments[0]->Get( isolate), "console", generatePreview);
352 } 352 }
353 353
354 V8MessageOrigin V8ConsoleMessage::origin() const 354 V8MessageOrigin V8ConsoleMessage::origin() const
355 { 355 {
356 return m_origin; 356 return m_origin;
357 } 357 }
358 358
359 unsigned V8ConsoleMessage::argumentCount() const
360 {
361 return m_arguments.size();
362 }
363
364 ConsoleAPIType V8ConsoleMessage::type() const 359 ConsoleAPIType V8ConsoleMessage::type() const
365 { 360 {
366 return m_type; 361 return m_type;
367 } 362 }
368 363
369 // static 364 // static
370 std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(double t imestamp, ConsoleAPIType type, const std::vector<v8::Local<v8::Value>>& argument s, std::unique_ptr<V8StackTrace> stackTrace, InspectedContext* context) 365 std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(double t imestamp, ConsoleAPIType type, const std::vector<v8::Local<v8::Value>>& argument s, std::unique_ptr<V8StackTrace> stackTrace, InspectedContext* context)
371 { 366 {
372 std::unique_ptr<V8ConsoleMessage> message = wrapUnique(new V8ConsoleMessage( V8MessageOrigin::kConsole, timestamp, ConsoleAPIMessageSource, LogMessageLevel, String16())); 367 std::unique_ptr<V8ConsoleMessage> message = wrapUnique(new V8ConsoleMessage( V8MessageOrigin::kConsole, timestamp, ConsoleAPIMessageSource, LogMessageLevel, String16()));
373 if (stackTrace && !stackTrace->isEmpty()) { 368 if (stackTrace && !stackTrace->isEmpty()) {
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 } 480 }
486 } 481 }
487 482
488 void V8ConsoleMessageStorage::contextDestroyed(int contextId) 483 void V8ConsoleMessageStorage::contextDestroyed(int contextId)
489 { 484 {
490 for (size_t i = 0; i < m_messages.size(); ++i) 485 for (size_t i = 0; i < m_messages.size(); ++i)
491 m_messages[i]->contextDestroyed(contextId); 486 m_messages[i]->contextDestroyed(contextId);
492 } 487 }
493 488
494 } // namespace blink 489 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698