Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2141753002: [Extensions] Code cleanup - const &s (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Code cleanup - const &s More sprinkling of artisanal const &s. BUG=None Committed: https://crrev.com/00be25559585530d3f83684cd765610e7f196ba3 Cr-Commit-Position: refs/heads/master@{#405188}

Patch Set 1 #

Messages

Total messages: 24 (12 generated)
Devlin
Another one for you. :)
4 years, 5 months ago (2016-07-11 22:32:46 UTC) #4
lazyboy
lgtm
4 years, 5 months ago (2016-07-12 00:02:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141753002/1
4 years, 5 months ago (2016-07-12 00:06:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190667)
4 years, 5 months ago (2016-07-12 04:10:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141753002/1
4 years, 5 months ago (2016-07-12 04:40:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191029)
4 years, 5 months ago (2016-07-12 08:43:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141753002/1
4 years, 5 months ago (2016-07-12 14:50:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191463)
4 years, 5 months ago (2016-07-12 18:57:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141753002/1
4 years, 5 months ago (2016-07-13 15:56:41 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:40:53 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:41:05 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:42:06 UTC) #24
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/00be25559585530d3f83684cd765610e7f196ba3
Cr-Commit-Position: refs/heads/master@{#405188}

Powered by Google App Engine
This is Rietveld 408576698