chrome/common/extensions/chrome_manifest_url_handlers.cc - Issue 2141753002: [Extensions] Code cleanup - const &s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_url_handlers.cc

Issue 2141753002: [Extensions] Code cleanup - const &s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/chrome_manifest_url_handlers.cc

diff --git a/chrome/common/extensions/chrome_manifest_url_handlers.cc b/chrome/common/extensions/chrome_manifest_url_handlers.cc

index 200a53e6296c2b6d7785788a5c0082f9e4f67746..3d13dd9a32e5af2c764913c83ed21590761126ab 100644

--- a/chrome/common/extensions/chrome_manifest_url_handlers.cc

+++ b/chrome/common/extensions/chrome_manifest_url_handlers.cc

@@ -103,7 +103,7 @@ bool URLOverridesHandler::Parse(Extension* extension, base::string16* error) {

// Validate that the overrides are all strings

for (base::DictionaryValue::Iterator iter(*overrides); !iter.IsAtEnd();

iter.Advance()) {

- std::string page = iter.key();

+ const std::string& page = iter.key();

std::string val;

// Restrict override pages to a list of supported URLs.

bool is_allowed_host = page == chrome::kChromeUINewTabHost ||