[Extensions] Code cleanup - const &s

extensions/browser/api/printer_provider/printer_provider_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 313 matching lines @@
     return true;
   }
 
   // Validates that set of printers reported by test apps via
   // chrome.printerProvider.onGetPritersRequested is the same as the set of
   // printers in |expected_printers|. |expected_printers| contains list of
   // printer objects formatted as a JSON string. It is assumed that the values
   // in |expoected_printers| are unique.
   void ValidatePrinterListValue(
       const base::ListValue& printers,
-      const std::vector<std::unique_ptr<base::Value>> expected_printers) {
+      const std::vector<std::unique_ptr<base::Value>>& expected_printers) {
     ASSERT_EQ(expected_printers.size(), printers.GetSize());
     for (const auto& printer_value : expected_printers) {
       EXPECT_TRUE(printers.Find(*printer_value.get()) != printers.end())
           << "Unable to find " << *printer_value.get() << " in " << printers;
     }
   }
 
  protected:
   device::MockUsbService usb_service_;
 
@@ skipping 156 matching lines @@
           .Build());
   expected_printers.push_back(
       DictionaryBuilder()
           .Set("extensionId", extension_id)
           .Set("extensionName", "Test printer provider")
           .Set("id",
                base::StringPrintf("%s:printerNoDesc", extension_id.c_str()))
           .Set("name", "Printer 2")
           .Build());
 
-  ValidatePrinterListValue(printers, std::move(expected_printers));
+  ValidatePrinterListValue(printers, expected_printers);
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersAsyncSuccess) {
   ResultCatcher catcher;
 
   std::string extension_id;
   InitializePrinterProviderTestApp("api_test/printer_provider/request_printers",
                                    "ASYNC_RESPONSE", &extension_id);
   ASSERT_FALSE(extension_id.empty());
 
@@ skipping 10 matching lines @@
   std::vector<std::unique_ptr<base::Value>> expected_printers;
   expected_printers.push_back(
       DictionaryBuilder()
           .Set("description", "Test printer")
           .Set("extensionId", extension_id)
           .Set("extensionName", "Test printer provider")
           .Set("id", base::StringPrintf("%s:printer1", extension_id.c_str()))
           .Set("name", "Printer 1")
           .Build());
 
-  ValidatePrinterListValue(printers, std::move(expected_printers));
+  ValidatePrinterListValue(printers, expected_printers);
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersTwoExtensions) {
   ResultCatcher catcher;
 
   std::string extension_id_1;
   InitializePrinterProviderTestApp("api_test/printer_provider/request_printers",
                                    "OK", &extension_id_1);
   ASSERT_FALSE(extension_id_1.empty());
 
@@ skipping 41 matching lines @@
           .Build());
   expected_printers.push_back(
       DictionaryBuilder()
           .Set("extensionId", extension_id_2)
           .Set("extensionName", "Test printer provider")
           .Set("id",
                base::StringPrintf("%s:printerNoDesc", extension_id_2.c_str()))
           .Set("name", "Printer 2")
           .Build());
 
-  ValidatePrinterListValue(printers, std::move(expected_printers));
+  ValidatePrinterListValue(printers, expected_printers);
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,
                        GetPrintersTwoExtensionsBothUnloaded) {
   ResultCatcher catcher;
 
   std::string extension_id_1;
   InitializePrinterProviderTestApp("api_test/printer_provider/request_printers",
                                    "IGNORE_CALLBACK", &extension_id_1);
   ASSERT_FALSE(extension_id_1.empty());
@@ skipping 58 matching lines @@
           .Build());
   expected_printers.push_back(
       DictionaryBuilder()
           .Set("extensionId", extension_id_2)
           .Set("extensionName", "Test printer provider")
           .Set("id",
                base::StringPrintf("%s:printerNoDesc", extension_id_2.c_str()))
           .Set("name", "Printer 2")
           .Build());
 
-  ValidatePrinterListValue(printers, std::move(expected_printers));
+  ValidatePrinterListValue(printers, expected_printers);
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,
                        GetPrintersTwoExtensionsOneWithNoListener) {
   ResultCatcher catcher;
 
   std::string extension_id_1;
   InitializePrinterProviderTestApp("api_test/printer_provider/request_printers",
                                    "NO_LISTENER", &extension_id_1);
   ASSERT_FALSE(extension_id_1.empty());
@@ skipping 26 matching lines @@
           .Build());
   expected_printers.push_back(
       DictionaryBuilder()
           .Set("extensionId", extension_id_2)
           .Set("extensionName", "Test printer provider")
           .Set("id",
                base::StringPrintf("%s:printerNoDesc", extension_id_2.c_str()))
           .Set("name", "Printer 2")
           .Build());
 
-  ValidatePrinterListValue(printers, std::move(expected_printers));
+  ValidatePrinterListValue(printers, expected_printers);
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersNoListener) {
   ResultCatcher catcher;
 
   std::string extension_id;
   InitializePrinterProviderTestApp("api_test/printer_provider/request_printers",
                                    "NO_LISTENER", &extension_id);
   ASSERT_FALSE(extension_id.empty());
 
@@ skipping 110 matching lines @@
   RunUsbPrinterInfoRequestTest("EMPTY_RESPONSE");
 }
 
 IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetUsbPrinterInfoNoListener) {
   RunUsbPrinterInfoRequestTest("NO_LISTENER");
 }
 
 }  // namespace
 
 }  // namespace extensions