extensions/browser/api/printer_provider/printer_provider_apitest.cc - Issue 2141753002: [Extensions] Code cleanup - const &s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_apitest.cc

Issue 2141753002: [Extensions] Code cleanup - const &s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/automation.cc ('k') | extensions/browser/api/system_network/system_network_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_apitest.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_apitest.cc b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

index ca949ec43c5b6c54021b200800b7f49f9b8cf040..bed4bcef298759bf0fc4a8dc082a0cf38a75a5e7 100644

--- a/extensions/browser/api/printer_provider/printer_provider_apitest.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

@@ -331,7 +331,7 @@ class PrinterProviderApiTest : public ShellApiTest {

// in |expoected_printers| are unique.

void ValidatePrinterListValue(

const base::ListValue& printers,

- const std::vector<std::unique_ptr<base::Value>> expected_printers) {

+ const std::vector<std::unique_ptr<base::Value>>& expected_printers) {

ASSERT_EQ(expected_printers.size(), printers.GetSize());

for (const auto& printer_value : expected_printers) {

EXPECT_TRUE(printers.Find(*printer_value.get()) != printers.end())

@@ -508,7 +508,7 @@ IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersSuccess) {

.Set("name", "Printer 2")

.Build());

- ValidatePrinterListValue(printers, std::move(expected_printers));

+ ValidatePrinterListValue(printers, expected_printers);

}

IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersAsyncSuccess) {

@@ -539,7 +539,7 @@ IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersAsyncSuccess) {

.Set("name", "Printer 1")

.Build());

- ValidatePrinterListValue(printers, std::move(expected_printers));

+ ValidatePrinterListValue(printers, expected_printers);

}

IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersTwoExtensions) {

@@ -601,7 +601,7 @@ IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersTwoExtensions) {

.Set("name", "Printer 2")

.Build());

- ValidatePrinterListValue(printers, std::move(expected_printers));

+ ValidatePrinterListValue(printers, expected_printers);

}

IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,

@@ -680,7 +680,7 @@ IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,

.Set("name", "Printer 2")

.Build());

- ValidatePrinterListValue(printers, std::move(expected_printers));

+ ValidatePrinterListValue(printers, expected_printers);

}

IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,

@@ -727,7 +727,7 @@ IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest,

.Set("name", "Printer 2")

.Build());

- ValidatePrinterListValue(printers, std::move(expected_printers));

+ ValidatePrinterListValue(printers, expected_printers);

}

IN_PROC_BROWSER_TEST_F(PrinterProviderApiTest, GetPrintersNoListener) {