chrome/common/extensions/command_unittest.cc - Issue 2141753002: [Extensions] Code cleanup - const &s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/command_unittest.cc

Issue 2141753002: [Extensions] Code cleanup - const &s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/command_unittest.cc

diff --git a/chrome/common/extensions/command_unittest.cc b/chrome/common/extensions/command_unittest.cc

index d5e489aa81942f2cb5c0179f6cd88c36b7e49ecd..5edc4ce21233c082323e69d3da67d63b4389e360 100644

--- a/chrome/common/extensions/command_unittest.cc

+++ b/chrome/common/extensions/command_unittest.cc

@@ -32,7 +32,7 @@ typedef const struct {

// |platform_specific_only| is true, only the latter is tested. |platforms|

// specifies all platforms to use when populating the |suggested_key|

// dictionary.

-void CheckParse(ConstCommandsTestData data,

+void CheckParse(const ConstCommandsTestData& data,

int i,

bool platform_specific_only,

std::vector<std::string>& platforms) {